[DEFAULT] strict_cors_mode should be independent from [DEFAULT] cors_allow_origin

Bug #2048840 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-swift
Fix Released
Undecided
Unassigned

Bug Description

Currently the [DEFAULT] strict_cors_mode option can be customized only when the [DEFAULT] cors_allow_origin option is set, but this is redundant in case a user wants to disable strict cors mode (which requires only setting strict_cors_mode=False).

We should allow users to set these parameters independently.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)
Changed in puppet-swift:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/905187
Committed: https://opendev.org/openstack/puppet-swift/commit/185fe9b25e8784b51c3249b323869d7b9a1c8049
Submitter: "Zuul (22348)"
Branch: master

commit 185fe9b25e8784b51c3249b323869d7b9a1c8049
Author: Takashi Kajinami <email address hidden>
Date: Wed Jan 10 15:41:50 2024 +0900

    Fix handling of cors options

    The strict_cors_mode option should be set independently from
    the cors_allow_origin, for example in case when strict mode is
    disabled.

    Also the current description about the strict_cors_mode is completely
    incorrect.

    This fixes these problems, and also allows usage of an array value
    for cors_allow_origin so that users can compose a value to be passed
    to the parameter more easily.

    NOTE:
    The strict_cors_mode option defaults to true in swift, thus its default
    is replaced by the os_service_default fact.

    Closes-Bug: #2048840
    Change-Id: I59317519e31349d0b0b7efafae3a0a8a44d81d37

Changed in puppet-swift:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 24.0.0

This issue was fixed in the openstack/puppet-swift 24.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.