Creating an object ring for customized storage policies causes type validation warning

Bug #1987260 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-swift
Fix Released
High
Takashi Kajinami

Bug Description

When creating an object ring for customized storage policy by swift::ringbuildeR::policy_ring, the following warning is always shown.

Example:
https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_e7f/850122/13/check/puppet-openstack-litmus-7.16-centos-9-stream/e7fa282/job-output.txt

Warning: validate_legacy(validate_re) expects a match for Enum['account', 'container', 'object'], got 'object-1' at ["/home/zuul/workspace/spec/fixtures/modules/swift/manifests/ringbuilder/create.pp", 44]:

Changed in puppet-swift:
importance: Undecided → High
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)
Changed in puppet-swift:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/853929
Committed: https://opendev.org/openstack/puppet-swift/commit/11b193cab8f880f1b73c57208646a889979e6fd8
Submitter: "Zuul (22348)"
Branch: master

commit 11b193cab8f880f1b73c57208646a889979e6fd8
Author: Takashi Kajinami <email address hidden>
Date: Mon Aug 22 17:11:34 2022 +0900

    Fix type validation warning for storage policy rings

    Since 63688a14e57282ae97072b406c81d0da2f61965c was merged, this module
    support configuring storage policies.

    When multiple storage policies are used, we need to create multiple
    object rings like object.ring.gz, object-1.ring.gz. However the current
    regexp to validate the ring name does not consider this format and
    shows the type validation warning when creating a non-default policy
    rings.

    This change updates the regexp used in validation to accept that
    object-<number> format as well.

    Closes-Bug: #1987260
    Change-Id: Ibc7479e7defbfa4c49bf3c9f1574cdcf61b90ab9

Changed in puppet-swift:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/yoga)

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/puppet-swift/+/854538

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/yoga)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/854538
Committed: https://opendev.org/openstack/puppet-swift/commit/2d1b0a7f8a188b546b5f54fb1fd5372d7f47b350
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 2d1b0a7f8a188b546b5f54fb1fd5372d7f47b350
Author: Takashi Kajinami <email address hidden>
Date: Mon Aug 22 17:11:34 2022 +0900

    Fix type validation warning for storage policy rings

    Since 63688a14e57282ae97072b406c81d0da2f61965c was merged, this module
    support configuring storage policies.

    When multiple storage policies are used, we need to create multiple
    object rings like object.ring.gz, object-1.ring.gz. However the current
    regexp to validate the ring name does not consider this format and
    shows the type validation warning when creating a non-default policy
    rings.

    This change updates the regexp used in validation to accept that
    object-<number> format as well.

    Closes-Bug: #1987260
    Change-Id: Ibc7479e7defbfa4c49bf3c9f1574cdcf61b90ab9
    (cherry picked from commit 11b193cab8f880f1b73c57208646a889979e6fd8)

tags: added: in-stable-yoga
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-swift/+/856873

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/856873
Committed: https://opendev.org/openstack/puppet-swift/commit/ced957d7424b237afe3a010a1aacc20d24e6cf9f
Submitter: "Zuul (22348)"
Branch: stable/xena

commit ced957d7424b237afe3a010a1aacc20d24e6cf9f
Author: Takashi Kajinami <email address hidden>
Date: Mon Aug 22 17:11:34 2022 +0900

    Fix type validation warning for storage policy rings

    Since 63688a14e57282ae97072b406c81d0da2f61965c was merged, this module
    support configuring storage policies.

    When multiple storage policies are used, we need to create multiple
    object rings like object.ring.gz, object-1.ring.gz. However the current
    regexp to validate the ring name does not consider this format and
    shows the type validation warning when creating a non-default policy
    rings.

    This change updates the regexp used in validation to accept that
    object-<number> format as well.

    Closes-Bug: #1987260
    Change-Id: Ibc7479e7defbfa4c49bf3c9f1574cdcf61b90ab9
    (cherry picked from commit 11b193cab8f880f1b73c57208646a889979e6fd8)
    (cherry picked from commit 2d1b0a7f8a188b546b5f54fb1fd5372d7f47b350)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-swift/+/857063

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/857063
Committed: https://opendev.org/openstack/puppet-swift/commit/dd894095338f8fadae813028f4ff0fcc2542e0e2
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit dd894095338f8fadae813028f4ff0fcc2542e0e2
Author: Takashi Kajinami <email address hidden>
Date: Mon Aug 22 17:11:34 2022 +0900

    Fix type validation warning for storage policy rings

    Since 63688a14e57282ae97072b406c81d0da2f61965c was merged, this module
    support configuring storage policies.

    When multiple storage policies are used, we need to create multiple
    object rings like object.ring.gz, object-1.ring.gz. However the current
    regexp to validate the ring name does not consider this format and
    shows the type validation warning when creating a non-default policy
    rings.

    This change updates the regexp used in validation to accept that
    object-<number> format as well.

    Closes-Bug: #1987260
    Change-Id: Ibc7479e7defbfa4c49bf3c9f1574cdcf61b90ab9
    (cherry picked from commit 11b193cab8f880f1b73c57208646a889979e6fd8)
    (cherry picked from commit 2d1b0a7f8a188b546b5f54fb1fd5372d7f47b350)
    (cherry picked from commit ced957d7424b237afe3a010a1aacc20d24e6cf9f)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 20.4.0

This issue was fixed in the openstack/puppet-swift 20.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 21.0.0

This issue was fixed in the openstack/puppet-swift 21.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 18.6.0

This issue was fixed in the openstack/puppet-swift 18.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 19.5.0

This issue was fixed in the openstack/puppet-swift 19.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.