puppet-swift

SwiftRingBuilder: Updating weight fails with 'wrong number of arguments (given 0, expected 1)'

Bug #1949334 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-swift
Fix Released
Critical
Takashi Kajinami

Bug Description

When we try to update weight of devices in existing rings, puppet apply fails with the following error.

puppet-user: Error: /Stage[main]/Test::Ring_object_device[192.168.0.11:6000/sdb]/weight: change from '100.00' to '120.00' failed: wrong number of arguments (given 0, expected 1)

This issue seem to be caused by the change which introduced support for storage policies.

https://github.com/openstack/puppet-swift/commit/63688a14e57282ae97072b406c81d0da2f61965c

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-swift/+/816126

Changed in puppet-swift:
status: New → In Progress
Takashi Kajinami (kajinamit)
Changed in puppet-swift:
importance: Undecided → Critical
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/816126
Committed: https://opendev.org/openstack/puppet-swift/commit/350778570c04db749a61106f173419b25fd7494f
Submitter: "Zuul (22348)"
Branch: master

commit 350778570c04db749a61106f173419b25fd7494f
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 1 16:43:58 2021 +0900

    Fix missing argument of builder_file_path

    The change 63688a14e57282ae97072b406c81d0da2f61965c introduced support
    of storage policies and since the change was merged builder_file_path
    takes one argument which is policy_index .

    This change fixes the function call without argument to avoid failure
    caused by missing argument.

    Closes-Bug: #1949334
    Change-Id: I987a37cb0606b6c217f906fbae17a765e40f4580

Changed in puppet-swift:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-swift/+/816237

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-swift/+/816238

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/puppet-swift/+/816239

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/puppet-swift/+/816240

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/puppet-swift/+/816241

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/816237
Committed: https://opendev.org/openstack/puppet-swift/commit/e7d560738d5e02d32e63a0411211ddbb8afdcd9c
Submitter: "Zuul (22348)"
Branch: stable/xena

commit e7d560738d5e02d32e63a0411211ddbb8afdcd9c
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 1 16:43:58 2021 +0900

    Fix missing argument of builder_file_path

    The change 63688a14e57282ae97072b406c81d0da2f61965c introduced support
    of storage policies and since the change was merged builder_file_path
    takes one argument which is policy_index .

    This change fixes the function call without argument to avoid failure
    caused by missing argument.

    Closes-Bug: #1949334
    Change-Id: I987a37cb0606b6c217f906fbae17a765e40f4580
    (cherry picked from commit 350778570c04db749a61106f173419b25fd7494f)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/816238
Committed: https://opendev.org/openstack/puppet-swift/commit/a8dc75e18323d8d1bf6e527fae3c5d056719c508
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit a8dc75e18323d8d1bf6e527fae3c5d056719c508
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 1 16:43:58 2021 +0900

    Fix missing argument of builder_file_path

    The change 63688a14e57282ae97072b406c81d0da2f61965c introduced support
    of storage policies and since the change was merged builder_file_path
    takes one argument which is policy_index .

    This change fixes the function call without argument to avoid failure
    caused by missing argument.

    Closes-Bug: #1949334
    Change-Id: I987a37cb0606b6c217f906fbae17a765e40f4580
    (cherry picked from commit 350778570c04db749a61106f173419b25fd7494f)
    (cherry picked from commit e7d560738d5e02d32e63a0411211ddbb8afdcd9c)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/816239
Committed: https://opendev.org/openstack/puppet-swift/commit/131ac86b488021c27d597f4a1e8682684dfacb2f
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 131ac86b488021c27d597f4a1e8682684dfacb2f
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 1 16:43:58 2021 +0900

    Fix missing argument of builder_file_path

    The change 63688a14e57282ae97072b406c81d0da2f61965c introduced support
    of storage policies and since the change was merged builder_file_path
    takes one argument which is policy_index .

    This change fixes the function call without argument to avoid failure
    caused by missing argument.

    Closes-Bug: #1949334
    Change-Id: I987a37cb0606b6c217f906fbae17a765e40f4580
    (cherry picked from commit 350778570c04db749a61106f173419b25fd7494f)
    (cherry picked from commit e7d560738d5e02d32e63a0411211ddbb8afdcd9c)
    (cherry picked from commit a8dc75e18323d8d1bf6e527fae3c5d056719c508)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/816240
Committed: https://opendev.org/openstack/puppet-swift/commit/edfaa3546a941467dcee9a0f268e1a90656b4526
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit edfaa3546a941467dcee9a0f268e1a90656b4526
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 1 16:43:58 2021 +0900

    Fix missing argument of builder_file_path

    The change 63688a14e57282ae97072b406c81d0da2f61965c introduced support
    of storage policies and since the change was merged builder_file_path
    takes one argument which is policy_index .

    This change fixes the function call without argument to avoid failure
    caused by missing argument.

    Closes-Bug: #1949334
    Change-Id: I987a37cb0606b6c217f906fbae17a765e40f4580
    (cherry picked from commit 350778570c04db749a61106f173419b25fd7494f)
    (cherry picked from commit e7d560738d5e02d32e63a0411211ddbb8afdcd9c)
    (cherry picked from commit a8dc75e18323d8d1bf6e527fae3c5d056719c508)
    (cherry picked from commit 131ac86b488021c27d597f4a1e8682684dfacb2f)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/train)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/816241
Committed: https://opendev.org/openstack/puppet-swift/commit/1c1cb38c701bcdec161ebbe66d5913f99359598b
Submitter: "Zuul (22348)"
Branch: stable/train

commit 1c1cb38c701bcdec161ebbe66d5913f99359598b
Author: Takashi Kajinami <email address hidden>
Date: Mon Nov 1 16:43:58 2021 +0900

    Fix missing argument of builder_file_path

    The change 63688a14e57282ae97072b406c81d0da2f61965c introduced support
    of storage policies and since the change was merged builder_file_path
    takes one argument which is policy_index .

    This change fixes the function call without argument to avoid failure
    caused by missing argument.

    Closes-Bug: #1949334
    Change-Id: I987a37cb0606b6c217f906fbae17a765e40f4580
    (cherry picked from commit 350778570c04db749a61106f173419b25fd7494f)
    (cherry picked from commit e7d560738d5e02d32e63a0411211ddbb8afdcd9c)
    (cherry picked from commit a8dc75e18323d8d1bf6e527fae3c5d056719c508)
    (cherry picked from commit 131ac86b488021c27d597f4a1e8682684dfacb2f)
    (cherry picked from commit edfaa3546a941467dcee9a0f268e1a90656b4526)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 20.0.0

This issue was fixed in the openstack/puppet-swift 20.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 16.4.0

This issue was fixed in the openstack/puppet-swift 16.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 18.5.0

This issue was fixed in the openstack/puppet-swift 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 17.5.0

This issue was fixed in the openstack/puppet-swift 17.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 19.5.0

This issue was fixed in the openstack/puppet-swift 19.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift train-eol

This issue was fixed in the openstack/puppet-swift train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.