is_<type> method is deprecated

Bug #1939088 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-keystone
Fix Released
Medium
Takashi Kajinami
puppet-neutron
Fix Released
Medium
Takashi Kajinami
puppet-nova
Fix Released
Medium
Takashi Kajinami
puppet-oslo
Fix Released
Medium
Takashi Kajinami
puppet-swift
Fix Released
Medium
Takashi Kajinami
tripleo
Fix Released
Medium
Takashi Kajinami

Bug Description

is_string, is_array and is_hash are all deprecated and result in a huge warning message like;

2021-08-06 01:27:40 +0000 Puppet (warning): This method is deprecated, please use match expressions with Stdlib::Compat::String instead. They are described at https://docs.puppet.com/puppet/latest/reference/lang_data_type.html#match-expressions. at ["/etc/puppetlabs/code/modules/keystone/manifests/cache.pp", 150]:["/etc/puppetlabs/code/modules/openstack_integration/manifests/keystone.pp", 63]
   (location: ...)

Changed in puppet-keystone:
importance: Undecided → Medium
assignee: nobody → Takashi Kajinami (kajinamit)
Changed in puppet-keystone:
status: New → In Progress
Changed in puppet-nova:
importance: Undecided → Medium
assignee: nobody → Takashi Kajinami (kajinamit)
Changed in puppet-oslo:
importance: Undecided → Medium
assignee: nobody → Takashi Kajinami (kajinamit)
Changed in puppet-swift:
importance: Undecided → Medium
assignee: nobody → Takashi Kajinami (kajinamit)
Changed in tripleo:
importance: Undecided → Medium
assignee: nobody → Takashi Kajinami (kajinamit)
Changed in puppet-oslo:
status: New → In Progress
Changed in tripleo:
status: New → In Progress
Changed in puppet-nova:
status: New → In Progress
Changed in puppet-swift:
status: New → In Progress
yatin (yatinkarel)
Changed in tripleo:
milestone: none → xena-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-keystone/+/803663
Committed: https://opendev.org/openstack/puppet-keystone/commit/312605e6226a3cd5fa94bb4f841fe08a98ac09d4
Submitter: "Zuul (22348)"
Branch: master

commit 312605e6226a3cd5fa94bb4f841fe08a98ac09d4
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 10:35:21 2021 +0900

    Replace deprecated is_string method

    Closes-Bug: #1939088
    Change-Id: If8f085b73f21018e05eefc907071a69a665ce879

Changed in puppet-keystone:
status: In Progress → Fix Released
Changed in puppet-oslo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-oslo (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-oslo/+/803664
Committed: https://opendev.org/openstack/puppet-oslo/commit/8f6788f10f9c5df893beda7a2cb3ecfd6ee11ac3
Submitter: "Zuul (22348)"
Branch: master

commit 8f6788f10f9c5df893beda7a2cb3ecfd6ee11ac3
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 10:39:01 2021 +0900

    Replace deprecated is_string method

    ... and simplify how $::os_service_default, which is a String, is
    handled.

    Closes-Bug: #1939088
    Change-Id: Iafb03a6cd57859d11713d12b1c939a9fe782ee65

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-nova/+/803666
Committed: https://opendev.org/openstack/puppet-nova/commit/25a50136694bba86de7a33780dfdc97a83ca9093
Submitter: "Zuul (22348)"
Branch: master

commit 25a50136694bba86de7a33780dfdc97a83ca9093
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 10:46:44 2021 +0900

    Replace deprecated is_string/is_array method

    Closes-Bug: #1939088
    Change-Id: I6caebefef8da76265dca15c01bcbb27af34b6aea

Changed in puppet-nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-keystone/+/804010

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-oslo (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-oslo/+/804011

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-nova/+/804012

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/803667
Committed: https://opendev.org/openstack/puppet-swift/commit/7d7d8679d6dc249e85ceb90f82d9017414414c0b
Submitter: "Zuul (22348)"
Branch: master

commit 7d7d8679d6dc249e85ceb90f82d9017414414c0b
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 10:50:15 2021 +0900

    Replace deprecated is_array method

    Closes-Bug: #1939088
    Change-Id: I59717abeb5ef120e811511a771f5c3cd491b850f

Changed in puppet-swift:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-swift/+/804016

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-nova/+/804012
Committed: https://opendev.org/openstack/puppet-nova/commit/9d884228b9dc9cc31d5b4fcf274dbfa506005d72
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9d884228b9dc9cc31d5b4fcf274dbfa506005d72
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 10:46:44 2021 +0900

    Replace deprecated is_string/is_array method

    Closes-Bug: #1939088
    Change-Id: I6caebefef8da76265dca15c01bcbb27af34b6aea
    (cherry picked from commit 25a50136694bba86de7a33780dfdc97a83ca9093)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-keystone/+/804010
Committed: https://opendev.org/openstack/puppet-keystone/commit/27eac2577b00f0e1378df08c9b6d2307e52fb346
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 27eac2577b00f0e1378df08c9b6d2307e52fb346
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 10:35:21 2021 +0900

    Replace deprecated is_string method

    Closes-Bug: #1939088
    Change-Id: If8f085b73f21018e05eefc907071a69a665ce879
    (cherry picked from commit 312605e6226a3cd5fa94bb4f841fe08a98ac09d4)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-oslo (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-oslo/+/804011
Committed: https://opendev.org/openstack/puppet-oslo/commit/1e9d3f46ba713fec05d806818fe2331c4e405db8
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1e9d3f46ba713fec05d806818fe2331c4e405db8
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 10:39:01 2021 +0900

    Replace deprecated is_string method

    ... and simplify how $::os_service_default, which is a String, is
    handled.

    Closes-Bug: #1939088
    Change-Id: Iafb03a6cd57859d11713d12b1c939a9fe782ee65
    (cherry picked from commit 8f6788f10f9c5df893beda7a2cb3ecfd6ee11ac3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (master)
Changed in puppet-neutron:
status: New → In Progress
Changed in puppet-neutron:
importance: Undecided → Medium
assignee: nobody → Takashi Kajinami (kajinamit)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/803668
Committed: https://opendev.org/openstack/puppet-tripleo/commit/1d1ab8ecf8edcd5a29cd9409e6e0d1e0c60488da
Submitter: "Zuul (22348)"
Branch: master

commit 1d1ab8ecf8edcd5a29cd9409e6e0d1e0c60488da
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 11:01:39 2021 +0900

    Replace deprecated is_string/is_array/is_hash method

    Closes-Bug: #1939088
    Change-Id: I9804a6b405c4df78ef17096adefeeaefb816e840

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-tripleo (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-tripleo/+/804169

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-neutron/+/804244
Committed: https://opendev.org/openstack/puppet-neutron/commit/a60669b6e46e4f00570a0c39bf3dfd286e28f5a3
Submitter: "Zuul (22348)"
Branch: master

commit a60669b6e46e4f00570a0c39bf3dfd286e28f5a3
Author: Takashi Kajinami <email address hidden>
Date: Wed Aug 11 23:07:02 2021 +0900

    Get rid of deprecated is_array method

    ... and update the logic to handle neutron::service_plugins to follow
    existing implementations to handle ListOpt. The updated logic allows
    using a flat string which is useful when only one item is used. Also,
    it is enforced the actual parameter is removed from conf file when
    the puppet parameter is set to $::os_service_default.

    Closes-Bug: #1939088
    Change-Id: I0921a1d7012a76b9e6523715ea569f2476426d6a

Changed in puppet-neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-neutron/+/804860

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/804016
Committed: https://opendev.org/openstack/puppet-swift/commit/c4c80d1f183d1a1ece9dc935b6cc651b77421bc2
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c4c80d1f183d1a1ece9dc935b6cc651b77421bc2
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 10:50:15 2021 +0900

    Replace deprecated is_array method

    Closes-Bug: #1939088
    Change-Id: I59717abeb5ef120e811511a771f5c3cd491b850f
    (cherry picked from commit 7d7d8679d6dc249e85ceb90f82d9017414414c0b)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-neutron/+/804860
Committed: https://opendev.org/openstack/puppet-neutron/commit/4b5e10094dbfda974f3ee26fb3eb8dc69761b007
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4b5e10094dbfda974f3ee26fb3eb8dc69761b007
Author: Takashi Kajinami <email address hidden>
Date: Wed Aug 11 23:07:02 2021 +0900

    Get rid of deprecated is_array method

    ... and update the logic to handle neutron::service_plugins to follow
    existing implementations to handle ListOpt. The updated logic allows
    using a flat string which is useful when only one item is used. Also,
    it is enforced the actual parameter is removed from conf file when
    the puppet parameter is set to $::os_service_default.

    Closes-Bug: #1939088
    Change-Id: I0921a1d7012a76b9e6523715ea569f2476426d6a
    (cherry picked from commit a60669b6e46e4f00570a0c39bf3dfd286e28f5a3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-tripleo (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-tripleo/+/804169
Committed: https://opendev.org/openstack/puppet-tripleo/commit/29605351d228032e44eb026dc830e758809fdf5a
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 29605351d228032e44eb026dc830e758809fdf5a
Author: Takashi Kajinami <email address hidden>
Date: Fri Aug 6 11:01:39 2021 +0900

    Replace deprecated is_string/is_array/is_hash method

    Closes-Bug: #1939088
    Change-Id: I9804a6b405c4df78ef17096adefeeaefb816e840
    (cherry picked from commit 1d1ab8ecf8edcd5a29cd9409e6e0d1e0c60488da)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-keystone 19.3.0

This issue was fixed in the openstack/puppet-keystone 19.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-neutron 19.3.0

This issue was fixed in the openstack/puppet-neutron 19.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-nova 19.3.0

This issue was fixed in the openstack/puppet-nova 19.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-oslo 19.3.0

This issue was fixed in the openstack/puppet-oslo 19.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 19.3.0

This issue was fixed in the openstack/puppet-swift 19.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-tripleo 16.0.0

This issue was fixed in the openstack/puppet-tripleo 16.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-keystone 18.5.0

This issue was fixed in the openstack/puppet-keystone 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-neutron 18.5.0

This issue was fixed in the openstack/puppet-neutron 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-nova 18.5.0

This issue was fixed in the openstack/puppet-nova 18.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-oslo 18.4.1

This issue was fixed in the openstack/puppet-oslo 18.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-swift 18.5.0

This issue was fixed in the openstack/puppet-swift 18.5.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.