swift proxy misconfigured after upgrade

[Steven Hardy]

Upgrade job is failing at https://review.openstack.org/#/c/420100/ and I just reproduced it locally:

swift-proxy fails to start like this:

  File "/usr/lib/python2.7/site-packages/swift/common/wsgi.py", line 66, in get_context
    object_type, name=name, global_conf=global_conf)
  File "/usr/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 408, in get_context
    object_type, name=name)
  File "/usr/lib/python2.7/site-packages/paste/deploy/loadwsgi.py", line 587, in find_config_section
    self.filename))
LookupError: No section 'container-quotas' (prefixed by 'filter') found in config /etc/swift/proxy-server.conf
[root@overcloud-controller-0 ~]# vim /etc/swift/proxy-server.conf
-bash: vim: command not found

[root@overcloud-controller-0 ~]# cat /etc/swift/proxy-server.conf | grep -B1 container-quotas
[pipeline:main]
pipeline = catch_errors healthcheck proxy-logging cache ratelimit bulk tempurl formpost authtoken keystone staticweb copy container-quotas account-quotas slo dlo versioned_writes proxy-logging proxy-server

AFAICS it's because these two sections are wrong (underscores instead of hyphens):
[filter:container_quotas]
use=egg:swift#container_quotas

[filter:account_quotas]
use=egg:swift#account_quotas

Should be:

[filter:container-quotas]
use=egg:swift#container_quotas

[filter:account-quotas]
use=egg:swift#account_quotas

Making this change manually seems to allow the proxy to start.

I wonder if this is actually a bug in puppet-swift, will investigate.

[Steven Hardy (shardy)]

https://github.com/openstack/swift/blob/master/etc/proxy-server.conf-sample#L730 seems to indicate it should be my manually fixed syntax, so I'll push a patch to puppet-swift and re-test, unsure atm why other folks aren't seeing this tho.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/421341

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/422682

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/422682
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2dee58a85abd3e2e653d52f41ccf155c17681c62
Submitter: Jenkins
Branch: master

commit 2dee58a85abd3e2e653d52f41ccf155c17681c62
Author: Steven Hardy <email address hidden>
Date: Thu Jan 19 15:08:40 2017 +0000

    Swift proxy align *-quotas with puppet-swift syntax

    puppet-swift has hard-coded sections which expect these to be
    *_quotas, without matching the pipeline to the sections swift
    proxy fails to start.

    Change-Id: I3ee94a9bc4b046051e5d814e82a69f759bea1296
    Closes-Bug: #1657167

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 6.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Steven Hardy (<email address hidden>) on branch: master
Review: https://review.openstack.org/421341

[Takashi Kajinami (kajinamit)]

The proposed fix for puppet-swift was abandoned and the issue was resolved within TripleO.

I'll close this from puppet-swift's side because there is nothing pending on us now.