missing option for memcache_servers for object-expirer and container-reconciler

[Marcus Furlong]

Currently, memcache_servers for proxy-server can be defined as follows:

  class { '::swift::proxy::cache':
    memcache_servers => ["192.168.1.100:11211"],
  }

This results in the following in /etc/swift/proxy-server.conf:

[filter:cache]
use = egg:swift#memcache
memcache_servers = 192.168.1.100:11211

/etc/swift/object-expirer.conf and /etc/swift/container-reconciler.conf can also use the same memcache_servers options (using the same format as above) but these options are missing in puppet-swift so they default to using 127.0.0.1:11211.

[Marcus Furlong (furlongm)]

I should also mention, the default settings result in logfiles being clogged with messages such as the following from object-expirer and container-reconciler:

Sep 27 16:06:42 s10 object-expirer: STDERR: ERROR:root:Error connecting to memcached: 127.0.0.1:11211#012Traceback (most recent call last):#012 File "/usr/lib/python2.7/site-packages/swift/common/memcached.py", line 214, in _get_conns#012 fp, sock = self._client_cache[server].get()#012 File "/usr/lib/python2.7/site-packages/swift/common/memcached.py", line 132, in get#012 fp, sock = self.create()#012 File "/usr/lib/python2.7/site-packages/swift/common/memcached.py", line 125, in create#012 sock.connect(sockaddr)#012 File "/usr/lib/python2.7/site-packages/eventlet/greenio/base.py", line 242, in connect#012 socket_checkerr(fd)#012 File "/usr/lib/python2.7/site-packages/eventlet/greenio/base.py", line 46, in socket_checkerr#012 raise socket.error(err, errno.errorcode[err])#012error: [Errno 111] ECONNREFUSED (txn: tx15d1bd615faf4a8c83f1f-0057ea0c72)

Sep 27 14:09:29 s10 container-reconciler: STDERR: ERROR:root:Error connecting to memcached: 127.0.0.1:11211#012Traceback (most recent call last):#012 File "/usr/lib/python2.7/site-packages/swift/common/memcached.py", line 214, in _get_conns#012 fp, sock = self._client_cache[server].get()#012 File "/usr/lib/python2.7/site-packages/swift/common/memcached.py", line 132, in get#012 fp, sock = self.create()#012 File "/usr/lib/python2.7/site-packages/swift/common/memcached.py", line 125, in create#012 sock.connect(sockaddr)#012 File "/usr/lib/python2.7/site-packages/eventlet/greenio/base.py", line 242, in connect#012 socket_checkerr(fd)#012 File "/usr/lib/python2.7/site-packages/eventlet/greenio/base.py", line 46, in socket_checkerr#012 raise socket.error(err, errno.errorcode[err])#012error: [Errno 111] ECONNREFUSED (txn: txbe4e522a72724243bb9ac-0057e9f0f9)

[Christian Schwede (cschwede)]

Marcus, are you still working on this? If not I'd like to submit a patch to fix this.

[Marcus Furlong (furlongm)]

Yes I had a review up, but looks like I forgot to add Closes-Bug. Will do that now.

[Christian Schwede (cschwede)]

Proposed fix: https://review.openstack.org/#/c/377304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/377304
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=d4922bee39b6ebf33eafe170154943a37a9aba0f
Submitter: Jenkins
Branch: master

commit d4922bee39b6ebf33eafe170154943a37a9aba0f
Author: Marcus Furlong <email address hidden>
Date: Tue Sep 27 17:50:21 2016 +1000

    memcache_servers support in object-expirer and container-reconciler

    This commit adds support for the memcache_servers option in
    object-expirer and container-reconciler. Without this, both
    currently default to 127.0.0.1:11211.

    Closes-Bug: #1627927
    Change-Id: Ie139f018c4a742b014dd4d682970e154d66a8c6d

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 10.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/503060

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/503060
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=6640132ebf509aee56764b3f0f52797d88474ddb
Submitter: Jenkins
Branch: stable/newton

commit 6640132ebf509aee56764b3f0f52797d88474ddb
Author: Marcus Furlong <email address hidden>
Date: Tue Sep 27 17:50:21 2016 +1000

    memcache_servers support in object-expirer and container-reconciler

    This commit adds support for the memcache_servers option in
    object-expirer and container-reconciler. Without this, both
    currently default to 127.0.0.1:11211.

    Closes-Bug: #1627927
    Change-Id: Ie139f018c4a742b014dd4d682970e154d66a8c6d
    (cherry picked from commit d4922bee39b6ebf33eafe170154943a37a9aba0f)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 9.7.0 release.