puppet-swift does not support statsd config

Bug #1616512 reported by David Johannsson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-swift
Fix Released
Medium
Alex Schultz

Bug Description

puppet-swift module does not support configuring log_statsd* params in object-server.conf. The module uses object-server.conf.erb template for configuration which might be not so good of an idea.

Why it might not be a good idea is when you use ::swift::storage::server to configure the object-server and want to add params like log_statsd* you then try to add them via swift_object_config.

What then happens is that swift_object_config writes the values to the conf but ::swift::storage::server overwrites them.

see: http://paste.openstack.org/show/563084/

It would be nice to either be able to pass a hash of key-value pairs to the define or include all legal params the servers have possible

Changed in puppet-swift:
status: New → Confirmed
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/360032

Changed in puppet-swift:
assignee: nobody → Alex Schultz (alex-schultz)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.openstack.org/360032
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=658f6589de653514f8881156daddf833a4b20559
Submitter: Jenkins
Branch: master

commit 658f6589de653514f8881156daddf833a4b20559
Author: Alex Schultz <email address hidden>
Date: Wed Aug 24 12:02:53 2016 -0600

    Add statsd configuration options

    This change adds the ability to configure the statsd configuration
    options for the account, container, object and proxy services.

    Change-Id: I9b06c86b44162cbd35b0aa3a5d237dcc5eea318b
    Closes-Bug: #1616512

Changed in puppet-swift:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-swift 9.2.0

This issue was fixed in the openstack/puppet-swift 9.2.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.