Duplicate declaration when defining swift::storage::* outside swift::storage::server

[Jiří Stránský]

Error: Duplicate declaration: Class[Swift::Storage::Account] is already declared in file /var/lib/heat-config/heat-config-puppet/e890965a-f5f4-4526-932c-c0982f6e03a7.pp:812; cannot redeclare at /etc/puppet/modules/swift/manifests/storage/server.pp:182 on node overcloud-controller-1.localdomain

We hit this in TripleO HA CI when trying to pass $manage_service and $enable params like here:

https://github.com/openstack/tripleo-heat-templates/blob/99bd9970d6bedee8228a6c8ff3d6f45aa1380e22/puppet/manifests/overcloud_controller_pacemaker.pp#L809-L820

It seems that declaring the classes this way is no longer possible after https://review.openstack.org/#/c/203220/ has landed.

[Jiří Stránský (jistr)]

Adding TripleO project and marking critical, as the CI is down because of this. I'll submit a temporary pin to an older version of puppet-swift.

For the final solution in puppet swift, i think Vinsh plans to go back to the include-like style for swift::storage::${type} includes in swift::storage::server class.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/255315

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/255315
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=67df8085d0422d5eec43e52c0cd738c43e9b2d3f
Submitter: Jenkins
Branch: master

commit 67df8085d0422d5eec43e52c0cd738c43e9b2d3f
Author: Adam Vinsh <email address hidden>
Date: Wed Dec 9 10:13:28 2015 -0500

    Use include for swift::storage::${type}

    Require operator specify swiftinit provider
    on supported components rather then pass it through.

    Change-Id: I7e35c0a49f51e252573f46af9ba2a8eda968e3e2
    Closes-Bug: #1524381

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/263967

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263967
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=3ba578fba7666f20db5b53803ca52c5b9239f863
Submitter: Jenkins
Branch: stable/liberty

commit 3ba578fba7666f20db5b53803ca52c5b9239f863
Author: Adam Vinsh <email address hidden>
Date: Wed Dec 9 10:13:28 2015 -0500

    Use include for swift::storage::${type}

    Require operator specify swiftinit provider
    on supported components rather then pass it through.

    Change-Id: I7e35c0a49f51e252573f46af9ba2a8eda968e3e2
    Closes-Bug: #1524381
    (cherry picked from commit 67df8085d0422d5eec43e52c0cd738c43e9b2d3f)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-swift 7.1.0 release.