Cannot specify replicaton network in swift-object-device

Bug #1491660 reported by Mark Kirkwood
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
puppet-swift
In Progress
Wishlist
Alex Schultz

Bug Description

There appears to be no way to separate storage and replication networks in swift-object-device and friends.

My naive attempt was this:

class profiles::swift::stor {

  $storage_ip = hiera('profiles::swift::storage_ip')
  $replication_ip = hiera('profiles::swift::replication_ip')

  @@ring_object_device { "${storage_ip}:6000R${replication_ip}:6010/${name}":
      region => hiera('profiles::swift::region', 1),
      zone => hiera('profiles::swift::zone', 1),
      weight => hiera('profiles::swift::weight', 1),
  }

...while this sets up the two networks ok in the ring, it confuses the provider utterly and it tries to add the device repeatedly even if it is already there (I'm guessing - not a ruby pro - that it is comparing the storage part of the ring builder output to the entire passed in storage + replication string). If I've understood the problem properly this might be easy to correct!

description: updated
description: updated
Adam Vinsh (adam-vinsh)
Changed in puppet-swift:
assignee: nobody → Adam Vinsh (adam-vinsh)
status: New → In Progress
Revision history for this message
Mark Kirkwood (mark-kirkwood) wrote :

I decided it was time to learn a little ruby. I think pull request https://github.com/openstack/puppet-swift/pull/7 fixes the issue by amending the validators and provider for ring_xxx_device.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/302483

Changed in puppet-swift:
assignee: Adam Vinsh (adam-vinsh) → Mark Kirkwood (mark-kirkwood)
Cody Herriges (ody-cat)
Changed in puppet-swift:
importance: Undecided → Wishlist
Changed in puppet-swift:
assignee: Mark Kirkwood (mark-kirkwood) → Alex Schultz (alex-schultz)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-swift (master)

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/302483
Reason: Since this is in merge conflict and hasn't been touched in over a year, abandoning per our policy. Abandoning per our policy https://docs.openstack.org/puppet-openstack-guide/latest/contributor/reviews.html#abandonment

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.