make "log_requests" flag configurable, reduce account/object/container server logs

Bug #1484614 reported by Benedikt von St. Vieth
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-swift
Fix Released
Medium
Benedikt von St. Vieth

Bug Description

not much more to say, see [1] and [2]. By configuring this, one can massively reduce the log output of the account/object/container servers. And with less disk access there is more performance? :)

If accepted, i can modify the code to let it fit in the review process.

[1] https://github.com/BeneDicere/puppet-swift/commit/28bae203efa1dc4282790ec9cd5a6394bb5fc7ad
[2] https://github.com/BeneDicere/puppet-swift/commit/1865ee759a55a9643b83f0f5dbb3077954c236bb

Revision history for this message
Adam Vinsh (adam-vinsh) wrote :

Hello Benedikt,
Your suggestion makes good sense and is a welcome addition.
Feel free to propose a review in gerrit and add me to it as a reviewer.

Matt Fischer (mfisch)
Changed in puppet-swift:
assignee: nobody → Benedikt von St. Vieth (b-von-st-vieth)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/220621

Changed in puppet-swift:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.openstack.org/220621
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=c2bb2fb31ee4c5a23fe4a218f195da2699fdfe06
Submitter: Jenkins
Branch: master

commit c2bb2fb31ee4c5a23fe4a218f195da2699fdfe06
Author: Benedikt von St. Vieth <email address hidden>
Date: Fri Sep 4 20:39:01 2015 +0200

    provide means to disable log_requests in config templates

    it is hard coded into account, object and container config templates to log
    every request. Provide a means to disable log_requests via
    swift::storage::server and swift::storage::all, this reduces the log output.

    Change-Id: I2fd97c1406710bb0305955f8ff9b47f91c09e13d
    Closes-Bug: #1484614

Changed in puppet-swift:
status: In Progress → Fix Committed
Cody Herriges (ody-cat)
Changed in puppet-swift:
importance: Undecided → Medium
Cody Herriges (ody-cat)
Changed in puppet-swift:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.