remove POSIX users, groups and file modes

[Drew Fisher]

The 'file' types should not check for (and set) POSIX users, groups or file/directory modes for configuration files and directories.

ex: https://github.com/stackforge/puppet-keystone/blob/master/manifests/init.pp#L515

These attributes are typically delivered by the OS's packaging system and should not be overridden.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/185663

[Mike Dorman (mdorman-m)]

I suspect there are several other places in the openstack puppet modules where this is occurring. If you find any others, please add them through 'also affects project' option above. thanks!

[Drew Fisher (drew-fisher)]

I think I've got them all. I'm not too certain about tripleo or monesca, however.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/186092

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/185663
Committed: https://git.openstack.org/cgit/stackforge/puppet-keystone/commit/?id=2abad789290be9f9b5f06e7eac40b438748de84e
Submitter: Jenkins
Branch: master

commit 2abad789290be9f9b5f06e7eac40b438748de84e
Author: Drew Fisher <email address hidden>
Date: Tue May 26 10:49:47 2015 -0600

    remove POSIX users, groups and file modes

    Closes-Bug: #1458915

    Change-Id: I30d759697ed42dc35f8df8e231c9e012d2762894

[OpenStack Infra (hudson-openstack)]

Change abandoned by Drew Fisher (<email address hidden>) on branch: master
Review: https://review.openstack.org/186092
Reason: This changeset is abandoned in lieu of https://review.openstack.org/#/c/195135/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/209068

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/211593

[OpenStack Infra (hudson-openstack)]

Change abandoned by Drew Fisher (<email address hidden>) on branch: master
Review: https://review.openstack.org/196390
Reason: See last comment

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/209068
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=d4e1d939673eb56c5a2b29faeaa3b36f175eea21
Submitter: Jenkins
Branch: master

commit d4e1d939673eb56c5a2b29faeaa3b36f175eea21
Author: Drew Fisher <email address hidden>
Date: Tue Aug 4 07:30:58 2015 -0600

    Remove POSIX users, groups, and file modes.

    This patch removes File resources which should be delivered by packaging
    tools. These resources (files, directories, modes, users, and group
    attributes) could be in conflict with different OS packaging systems
    which isn't a desired result.

    Change-Id: Ia7a8a71ef897d989f10ab511e6aa0432693041a5
    Closes-Bug: #1458915

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/222146

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222146
Committed: https://git.openstack.org/cgit/openstack/puppet-sahara/commit/?id=fa0bda834b56614e4a34318ba07134377ab8fbd2
Submitter: Jenkins
Branch: master

commit fa0bda834b56614e4a34318ba07134377ab8fbd2
Author: Denis Egorenko <email address hidden>
Date: Thu Sep 10 14:34:08 2015 +0300

    Remove POSIX file modes.

    This patch removes File resources, which should be delivered by packaging
    tools. These resources (files and directories with attributes) could be in
    conflict with different OS packaging systems, which isn't a desired result.

    Change-Id: Ife7d6b061380ea5ddcdf581c22e0fa6b1d31da61
    Closes-bug: #1458915

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228462

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/228462
Reason: I'm going to split the patches, it will be easier to review.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228524

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/228593

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228593
Committed: https://git.openstack.org/cgit/openstack/puppet-ceilometer/commit/?id=409e35a77671e3b129ad387f5e03f57cbe91872c
Submitter: Jenkins
Branch: master

commit 409e35a77671e3b129ad387f5e03f57cbe91872c
Author: Emilien Macchi <email address hidden>
Date: Mon Sep 28 15:34:35 2015 -0400

    stop managing File resources

    Drop any 'File' resource that is already managed by upstream packaging.

    Partial-bug: #1458915

    Change-Id: I47b12069362a9ec707df71d41f91dcccfa318c13

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/228524
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=47ac5095b3b145f09cff5472aecb7561e944f8c8
Submitter: Jenkins
Branch: master

commit 47ac5095b3b145f09cff5472aecb7561e944f8c8
Author: Emilien Macchi <email address hidden>
Date: Mon Sep 28 12:07:11 2015 -0400

    Stop managing file modes

    File modes should be managed by packaging, not by Puppet.
    This patch aims to stop managing File { mode => } parameters.

    Partial-bug: #1458915
    Change-Id: Ic38317521ac4a91bfdf234ecb4c74e4b00e3d887

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/235604

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/235604
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=d9eaed5be4bd07f3b0be27fc6a26f491aec31c62
Submitter: Jenkins
Branch: master

commit d9eaed5be4bd07f3b0be27fc6a26f491aec31c62
Author: Drew Fisher <email address hidden>
Date: Thu Oct 15 16:30:56 2015 -0600

    Remove POSIX users, groups, and file modes.

    This patch removes the File resources of nova.conf for mode, user and
    group which should be delivered by packaging tools. These resources
    (mode, user, and group attributes) could be in conflict with different
    OS packaging systems which isn't a desired result.

    Change-Id: I4fac32742dc317b16a6af825ad7095f0d94f3e57
    Closes-Bug: #1458915

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/237612

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/237612
Committed: https://git.openstack.org/cgit/openstack/puppet-heat/commit/?id=679c8a3379bd48f8a293eb7c2ef1b392e3abcb7e
Submitter: Jenkins
Branch: master

commit 679c8a3379bd48f8a293eb7c2ef1b392e3abcb7e
Author: Drew Fisher <email address hidden>
Date: Tue Oct 20 08:40:56 2015 -0600

    Remove POSIX users, groups, and file modes.

    This patch removes the File, Group, and User resources of /etc/heat and
    /etc/heat/heat.conf which should be delivered by packaging tools. These
    resources (mode, user, and group attributes) could be in conflict with
    different OS packaging systems which isn't a desired result.

    Change-Id: I5d49f3fc06df295700377eb66f883c9780959f96
    Closes-Bug: #1458915

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/195684
Reason: I'm abandoning this patch for lack of time and interest from our community.

If anyone is interested to restore it, please ping me on IRC or email.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/276551

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/276551
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=8687450542b4cc993b066876485f517a7bb2b7f6
Submitter: Jenkins
Branch: master

commit 8687450542b4cc993b066876485f517a7bb2b7f6
Author: ZhongShengping <[e-mail]>
Date: Fri Feb 5 11:24:41 2016 +0800

    remove POSIX users, groups and file modes

    Change-Id: I782c5e428f9234bd0fff6cb3af217f051944fd7f
    Closes-Bug: #1458915

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/195684
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=b68858f7fea51ed89da345b7db19fd9df0220023
Submitter: Jenkins
Branch: master

commit b68858f7fea51ed89da345b7db19fd9df0220023
Author: Emilien Macchi <email address hidden>
Date: Thu Jun 25 13:21:51 2015 -0400

    Drop User/group resource dependency

    This patch is a squash between:
    * I35187a857ae6e67b301d62e30525eaab75707161
    * I30d759697ed42dc35f8df8e231c9e012d2762894

    It entirely drops the usage of User resource dependency.

    Note: since beaker jobs were failing with sepeparated patches, we
    decided to use one patchset so Beaker job can pass the CI.

    Change-Id: Id69eca0ce73ba7c16aca939821234717618f5ec4
    Closes-bug: #1458915
    Co-Authored-By: Drew Fisher <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/211593
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=637f986252dc8be244b25bf37744ce89c9be613b
Submitter: Jenkins
Branch: master

commit 637f986252dc8be244b25bf37744ce89c9be613b
Author: Drew Fisher <email address hidden>
Date: Tue Aug 11 08:28:45 2015 -0600

    Remove POSIX users, groups, and file modes.

    This patch removes File resources which should be delivered by packaging
    tools. These resources (files, directories, modes, users, and group
    attributes) could be in conflict with different OS packaging systems
    which isn't a desired result.

    Co-Authored-By: Ivan Berezovskiy <email address hidden>

    Closes-Bug: #1458915

    Change-Id: I02fe8cc99dcd56e16ac66136a0da244a1eeb630b

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-glance 9.0.0 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/337940

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/337940
Committed: https://git.openstack.org/cgit/openstack/puppet-designate/commit/?id=50c12167f67c42fc9a734ac10b1633d071e5d159
Submitter: Jenkins
Branch: master

commit 50c12167f67c42fc9a734ac10b1633d071e5d159
Author: David Moreau-Simard <email address hidden>
Date: Tue Jul 5 20:52:09 2016 -0400

    Remove POSIX users, groups and files managed by packaging

    Both RDO and UCA provide packaging for designate and this packaging
    takes care of creating the necessary user/group/directories.

    Change-Id: Ic6af7dadb94a9ce22ad924184715b729b36ed16b
    Related-Bug: #1458915

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/197336
Reason: This review is > 4 weeks without comment or failed Jenkins or merge conflict the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Alex Schultz (<email address hidden>) on branch: master
Review: https://review.openstack.org/195135
Reason: This review is > 4 weeks without comment or failed Jenkins or merge conflict the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.