latest puppet expects catalog to contain resources to for requires and subscribes

[Alex Schultz]

The unit tests for puppet 5 (running via latest) is failing on some modules because the catalog created in the test doesn't contain the resources being referenced in requires/subscribes. For example:

http://logs.openstack.org/70/480170/1/check/gate-puppet-ceph-puppet-unit-latest-centos-7/b26b6f1/console.html#_2017-07-04_12_56_43_698263
Could not find resource 'Class[Ceph]' in parameter 'require' at /home/jenkins/workspace/gate-puppet-ceph-puppet-unit-latest-centos-7/spec/fixtures/modules/ceph/manifests/key.pp:174 on node centos-7-rax-ord-9642162

This can be fixed by switching to anchors (with an include) or using a pre_condition in the tests to ensure the correct classes are includes. For most of the puppet-openstack modules we should be using the anchors provided by <class>::deps rather than referencing the actual package/service. For classes without a deps class, we may just need to use a pre_condition in the test to include the appropriate resources.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481749

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481753

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481759

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481761

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/481767

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481749
Committed: https://git.openstack.org/cgit/openstack/puppet-ceph/commit/?id=69b651ff4c061becf556b7b8443ffb160c6f6f39
Submitter: Jenkins
Branch: master

commit 69b651ff4c061becf556b7b8443ffb160c6f6f39
Author: Alex Schultz <email address hidden>
Date: Fri Jul 7 14:18:37 2017 -0600

    Fix tests for latest puppet

    Adding in a pre condition for the ceph key tests to resolve catalog
    failures in the unit tests under the latest version of puppet.

    Change-Id: Ie56f77c8ff841785e083e84c3d22eac9a5b64d75
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481753
Committed: https://git.openstack.org/cgit/openstack/puppet-cinder/commit/?id=02b35294a599bb714f1cae630aa1bf0bb40a237b
Submitter: Jenkins
Branch: master

commit 02b35294a599bb714f1cae630aa1bf0bb40a237b
Author: Alex Schultz <email address hidden>
Date: Fri Jul 7 14:36:19 2017 -0600

    Fix cinder::quota_set requires

    The quota set exec was using a non-existant anchor. This change updates
    it to use the cinder::install::end anchor instead.

    Change-Id: Ic9a2299416e7494918835428ba1e1ef311a5de2a
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/482003

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/482051

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481759
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=b479685940e27dea5fa86155e3a2ba6878865abc
Submitter: Jenkins
Branch: master

commit b479685940e27dea5fa86155e3a2ba6878865abc
Author: Alex Schultz <email address hidden>
Date: Fri Jul 7 15:04:35 2017 -0600

    Fix resource references for latest puppet

    In keystone we had some references to Execs that may or may not have been
    defined depending on the class parameters. The latest version of puppet
    has changed how the catalog is compiled exposing these possibly
    undefined references. This change updates to use resource collectors
    where applicable.

    Change-Id: Id5dcc42301b622e7f8331b0d61fdef8b7fea1992
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482051
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=90b78634df653eb3f7ab095ed1b3ef30297e4088
Submitter: Jenkins
Branch: master

commit 90b78634df653eb3f7ab095ed1b3ef30297e4088
Author: ZhongShengping <[e-mail]>
Date: Mon Jul 10 16:35:47 2017 +0800

    Fix dependency references

    The latest version of puppet now reports these as catalog failures so
    this change removes the unnecessary Package and Service references
    since those are already handled by ironic::deps and fixes the invalid
    anchor reference.

    Change-Id: I3ef0165c844c36d72f8b1042ac7d482ac4209667
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481767
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=f92390204f0b9dac6e14dbef439e318089cbef4d
Submitter: Jenkins
Branch: master

commit f92390204f0b9dac6e14dbef439e318089cbef4d
Author: Alex Schultz <email address hidden>
Date: Fri Jul 7 15:53:46 2017 -0600

    Update resource references for dependencies

    Newer versions of puppet are throwing catalog failures for resources
    that are not being included in the testing. In this case, the references
    should be updated to use our anchors from the neutron::deps class which
    resolves the failures under the latest version of puppet.

    Change-Id: I7ac3c90eb18118f90f0b92dabd3323a6575dac4c
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/482003
Committed: https://git.openstack.org/cgit/openstack/puppet-designate/commit/?id=4ab3a326e9bf82a56caa0ef66ac259d4da1236fe
Submitter: Jenkins
Branch: master

commit 4ab3a326e9bf82a56caa0ef66ac259d4da1236fe
Author: ZhongShengping <[e-mail]>
Date: Mon Jul 10 13:39:56 2017 +0800

    Fix dependency references

    The latest version of puppet now reports these as catalog failures so
    this change removes the unnecessary Package and Service references
    since those are already handled by designate::deps.

    Change-Id: I3e4d1ab3d8efe3bfd0755c4f2524a2fe193a0896
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481761
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=a981c38c160362ab7f1079e8e08c2dbe2b1e90ca
Submitter: Jenkins
Branch: master

commit a981c38c160362ab7f1079e8e08c2dbe2b1e90ca
Author: Alex Schultz <email address hidden>
Date: Fri Jul 7 15:20:47 2017 -0600

    Fix dependency references

    With the deps migration, we left some of the dependency references in
    place which was previously ignored by puppet unit tests. The latest
    version of puppet now reports these as catalog failures so this change
    removes the unnecessary Package and Service references since those are
    already handled by manila::deps and fixes the invalid anchor reference
    for the manila::type and manila::type_set resources.

    Change-Id: Ie4dc0ae559e8f9bc9657fa6ed8ecf53ccda7852d
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483500

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483731

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483735

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483737

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483738

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483739

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483742

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483744

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483753

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483756

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483760

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483764

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483739

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483731

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483735

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483737

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483738

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483744

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483753

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483756

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483760

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483764

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/483855

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/483500
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=3ee568800d9295bc2a4f843bd3ce74b109613c6b
Submitter: Jenkins
Branch: master

commit 3ee568800d9295bc2a4f843bd3ce74b109613c6b
Author: Emilien Macchi <email address hidden>
Date: Thu Jul 13 11:26:54 2017 -0700

    Update resource references for dependencies

    The latest version of puppet now reports these as catalog failures so
    this change removes the unnecessary references and the references
    should be updated.

    Closes-Bug: #1702964
    Change-Id: Iebc547aa92f9f40e4a633c57d79e6c9cddb5dd28

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-cinder 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-designate 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-keystone 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-manila 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-openstacklib 11.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 7.2.0 release.

[OpenStack Infra (hudson-openstack)]

Change abandoned by zhongshengping ([e-mail]) on branch: master
Review: https://review.openstack.org/483855

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/489725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/489725
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=ca1bdcfd7bf2888f4d7bfc57508079f96b9fb8d5
Submitter: Jenkins
Branch: master

commit ca1bdcfd7bf2888f4d7bfc57508079f96b9fb8d5
Author: Alex Schultz <email address hidden>
Date: Tue Aug 1 13:45:30 2017 -0600

    Fix resources for latest puppet

    Running the unit tests under the latest puppet fails because of
    undefined resources. This change updates the references to use
    collectors if they are optional or change the definitions in the files
    for resources that are defined in the existing class.

    Change-Id: Ic91a8d577675fd1f2fb21543320426bfe49b1a2e
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/483855
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=8686642562ea86cd2f1457ab332ecaad02088130
Submitter: Jenkins
Branch: master

commit 8686642562ea86cd2f1457ab332ecaad02088130
Author: ZhongShengping <[e-mail]>
Date: Fri Jul 14 15:47:52 2017 +0800

    Update resource references for dependencies

    The latest version of puppet now reports these as catalog failures so
    this change removes the unnecessary references and the references
    should be updated.

    Change-Id: I2001f8bb91ff70cf100140c7861606db459c2ad9
    Closes-Bug: #1702964
    Co-Authored-By: Alex Schultz <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/490260

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/490260
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=08661e0fef8e22176a44bf250e20b43c220db531
Submitter: Jenkins
Branch: master

commit 08661e0fef8e22176a44bf250e20b43c220db531
Author: ZhongShengping <[e-mail]>
Date: Thu Aug 3 08:48:54 2017 +0800

    Fix resources for latest puppet

    Running the unit tests under the latest puppet fails because of
    undefined resources. This change updates the references to use
    collectors if they are optional or change the definitions in the files
    for resources that are defined in the existing class.

    Change-Id: I5506a563c459baf9d34246a1d517e07a82e0f36b
    Closes-Bug: #1702964

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ceph 2.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 11.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 11.3.0 release.