puppet-openstack-unit-6.yy-centos-8-stream is failing

[Takashi Kajinami]

Unit test job on CentOS 8 Stream is consistently failing.

https://zuul.opendev.org/t/openstack/build/6e3f52c966214464859acbe37009f64c

We recently bumped puppet version from 6.14 to 6.21.1 but I see that the job failed with the same error even before we made that bump.

https://zuul.opendev.org/t/openstack/build/f4e894bad0ef486787b8cf5e152d3a78

It is observed that the following one test case consistently fails.

```
  1) pcmk_common functions pcmk_restart_resource? stonith resource
     Failure/Error: expect(pcmk_restart_resource?('stonith-fence_ipmilan-stonith-fence-1', "cib-resource.xml")).to eq true

       expected: true
            got: false

       (compared using ==)

       Diff:
       @@ -1 +1 @@
       -true
       +false

     # ./spec/unit/puppet/provider/pcmk_common_spec.rb:41:in `block (2 levels) in <top (required)>'
```

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-pacemaker/+/803007

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-pacemaker/+/803007
Committed: https://opendev.org/openstack/puppet-pacemaker/commit/531283ecea579bf0576bd515770d9cf6513e48c7
Submitter: "Zuul (22348)"
Branch: master

commit 531283ecea579bf0576bd515770d9cf6513e48c7
Author: Michele Baldessari <email address hidden>
Date: Fri Jul 30 14:47:28 2021 +0200

    Fix spec tests using the deprecated pacemaker_restart_resource? function

    Currently we get the following error:

      1) pcmk_common functions pcmk_restart_resource? stonith resource
         Failure/Error: expect(pcmk_restart_resource?('stonith-fence_ipmilan-stonith-fence-1', "cib-resource.xml")).to eq true

           expected: true
                got: false

           (compared using ==)

           Diff:
           @@ -1 +1 @@
           -true
           +false

         # ./spec/unit/puppet/provider/pcmk_common_spec.rb:41:in `block (2 levels) in <top (required)>'

    Reason for this is that there are two functions to detect a change in a
    pcmk resource:
    - pacemaker_restart_resource? -> which parses crm_simulate and was
      necessary due to https://bugzilla.redhat.com/show_bug.cgi?id=1561617
      (Fixed in pacemaker-1.1.18-12)
    - pacemaker_restart_resource_ng? -> which is the preferred one and uses
      crm_diff xml output.

    The problem in CI is that crm_simulate output slightly changed and so
    one test is failing. Since it makes no sense to call
    pacemaker_restart_resource? with a working crm_diff (i.e. any pacemaker
    > 1.1.18-12), we just make sure we do not run these tests on a working
    crm_diff.

    We plan to remove pacemaker_restart_resource? fully now that newton (and
    el7) is unsupported, so this change is a minimal non-invasive fix for
    the time being.

    Closes-Bug: #1921118

    Change-Id: Ic8a8e127004220bb8b6735b6cf8b4b52c03fa825

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Michele Baldessari <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/puppet-pacemaker/+/782908

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-pacemaker 1.3.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/1.1.x
Review: https://review.opendev.org/c/openstack/puppet-pacemaker/+/880304

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Takashi Kajinami <email address hidden>" on branch: stable/1.1.x
Review: https://review.opendev.org/c/openstack/puppet-pacemaker/+/880304
Reason: tripleo is being retired