spec broken for ubuntu 18.04 and puppet 4.8

[Sofer Athlan-Guyot]

Hi,

as seen in [1]

2018-11-04 18:38:46.066249 | centos-7 | 1) pacemaker::new::service on ubuntu-18.04-x86_64 with default parameters should compile into a catalogue without dependency cycles
2018-11-04 18:38:46.066402 | centos-7 | Failure/Error: it { is_expected.to compile.with_all_deps }
2018-11-04 18:38:46.066470 | centos-7 | RuntimeError:
2018-11-04 18:38:46.066641 | centos-7 | Could not find the daemon directory (tested [/etc/sv,/var/lib/service])
2018-11-04 18:38:46.066691 | centos-7 |
2018-11-04 18:38:46.066887 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/provider/service/runit.rb:50:in `defpath'
2018-11-04 18:38:46.067118 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type/service.rb:180:in `block (3 levels) in <module:Puppet>'
2018-11-04 18:38:46.067311 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:834:in `set_default'
2018-11-04 18:38:46.067515 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.7.1/lib/rspec-puppet/monkey_patches.rb:87:in `call'
2018-11-04 18:38:46.067744 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.7.1/lib/rspec-puppet/monkey_patches.rb:87:in `block in <class:Type>'
2018-11-04 18:38:46.067942 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2493:in `block in set_parameters'
2018-11-04 18:38:46.068106 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2492:in `each'
2018-11-04 18:38:46.068301 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2492:in `set_parameters'
2018-11-04 18:38:46.068480 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/type.rb:2389:in `initialize'
2018-11-04 18:38:46.068648 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource.rb:489:in `new'
2018-11-04 18:38:46.068820 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource.rb:489:in `to_ral'
2018-11-04 18:38:46.069029 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:632:in `block in to_catalog'
2018-11-04 18:38:46.069240 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:624:in `each'
2018-11-04 18:38:46.069439 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:624:in `to_catalog'
2018-11-04 18:38:46.069626 | centos-7 | # ./.bundled_gems/gems/puppet-4.8.2/lib/puppet/resource/catalog.rb:511:in `to_ral'
2018-11-04 18:38:46.069846 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.7.1/lib/rspec-puppet/matchers/compile.rb:141:in `cycles_found?'
2018-11-04 18:38:46.070061 | centos-7 | # ./.bundled_gems/gems/rspec-puppet-2.7.1/lib/rspec-puppet/matchers/compile.rb:25:in `matches?'
2018-11-04 18:38:46.070275 | centos-7 | # ./spec/classes/pacemaker_service_spec.rb:13:in `block (5 levels) in <top (required)>'

It appears that the workaround used there[2] doesn't work anymore.

[1] http://logs.openstack.org/98/609998/6/check/puppet-openstack-unit-4.8-centos-7/903fc67/job-output.txt.gz
[2] https://bugs.launchpad.net/puppet-pacemaker/+bug/1783302

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/616249

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Note I triggered a dummy test job to be sure that the current testing was broken, and it is, see[1], so we need to merge a fix soon.

[1] https://review.openstack.org/#/c/616250/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616249
Committed: https://git.openstack.org/cgit/openstack/puppet-pacemaker/commit/?id=fafb72f48866ed8c15a199111860eaadbed72aab
Submitter: Zuul
Branch: master

commit fafb72f48866ed8c15a199111860eaadbed72aab
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Nov 7 17:44:24 2018 +0100

    Skip some tests for Ubuntu 18.04 and puppet 4.8.

    We already had an issue and we fixed it with an hack[1]. Puppet would
    assign runit service provider for Ubuntu. runit being the fallback
    when nothing else match.

    As a matter of fact puppet doesn't properly detect Ubuntu 18.04
    systemd usage before puppet 5. For instance here the code for the 4.x
    branch[2]:

        defaultfor :operatingsystem => :ubuntu, :operatingsystemmajrelease => ["15.04","15.10","16.04","16.10","17.04","17.10"]

    So let's get rid of those tests for 4.8 and Ubuntu 18.04.

    I only test < 5 as the first maintained branch is 5.3 and has the
    support for Ubuntu 18.04 services.

    [1] https://bugs.launchpad.net/puppet-pacemaker/+bug/1783302
    [2] https://github.com/puppetlabs/puppet/blob/4.10.x/lib/puppet/provider/service/systemd.rb#L28

    Change-Id: I9828b9a837c652fdc87131a84c73591c4e84d387
    Closes-Bug: #1802140

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-pacemaker 0.7.2 release.