"Allow more than one order rule between two resources." broke idempotency

[Michele Baldessari]

The Change-ID Ie543e9855e141c2c38b55571d3a3639fd1496bc3 "Allow more than one order rule between two resources" broke idempotency on ordering constraints:

Oct 13 15:41:44 localhost puppet-user[40079]: pcs -f /var/lib/pacemaker/cib/puppet-cib-backup20171013-40079-mzsv8d create constraint failed: Error: duplicate constraint already exists, use --force to override

The reason for this is that the code in lib/puppet/provider/pcmk_constraint/default.rb in exists? will never return true any long because the pcs output will never match the resource_name

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/512082

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/512082
Committed: https://git.openstack.org/cgit/openstack/puppet-pacemaker/commit/?id=5d98d82967e138d8b2bf8b7cb5205377b9d00fa5
Submitter: Jenkins
Branch: master

commit 5d98d82967e138d8b2bf8b7cb5205377b9d00fa5
Author: Michele Baldessari <email address hidden>
Date: Sun Oct 15 11:15:26 2017 +0000

    Revert "Allow more than one order rule between two resources."

    This reverts commit 4131dcee8dbd5f763a8a890a8577da411c6efbd3.

    See the following bug for a more detailed explanation:
    Closes-Bug: #1723729

    Change-Id: I607927c2ee5c29b605e18e9294b0f91d37337680

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-pacemaker 0.7.0 release.