Action parameter missing in generated stonith fence manifests

[Devon Mizelle]

Greetings,

I posted this on openstack-dev@ and was instructed to submit a bug report here, so the following is copy/pasted from the e-mail (sort of):

Noted here, there is an 'action' parameter defined for fence_ifmib:

https://github.com/openstack/puppet-pacemaker/blob/f62805f678f6fd8a260118279f6e0dbb05bff3d1/agent_generator/src_xml/fence_ifmib.xml#L83

However, in the generated manifest here, it seems that the 'action'
parameter is missing:

https://github.com/openstack/puppet-pacemaker/blob/f62805f678f6fd8a260118279f6e0dbb05bff3d1/manifests/stonith/fence_ifmib.pp

It looks like the 'action' parameter is missing in every fence_*
manifest (and has never existed.) I need this available to me so that
I can override the default action of fence_ifmib (which is 'reboot')
and set it to 'off'.

It looks like that in the agent_generator.rb script, action is being
specifically ignored in addition to 'help' and 'version' parameters.

Thanks,
Devon

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/332237

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/332237
Committed: https://git.openstack.org/cgit/openstack/puppet-pacemaker/commit/?id=5c6b52be1fa9f6b0821d79b7d81d72b50081ac0a
Submitter: Jenkins
Branch: master

commit 5c6b52be1fa9f6b0821d79b7d81d72b50081ac0a
Author: Devon Mizelle <email address hidden>
Date: Tue Jun 21 16:28:25 2016 +0000

    Removing ignoring the action parameter in the agent_generator.rb
    so that the manifests for the fencing scripts will have the parameter
    available to them.

    Change-Id: Iafbb04454a4f54ee8d8a70e4c5c8db0ba690945f
    Closes-Bug: 1594870