CI broken with "Cannot reassign variable package_provider"

[Sofer Athlan-Guyot]

This review, https://review.openstack.org/#/c/304190/, which changes
nothing to the module, fails to pass the CI:

http://logs.openstack.org/90/304190/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-centos-7/9a2160a/console.html#_2016-04-11_15_55_55_751

     1) openstacklib class default parameters should work with no errors
        Failure/Error: apply_manifest(pp, :catch_failures => true)
        Beaker::Host::CommandFailure:
          Host 'centos-70-x64' exited with 1 running:
           puppet apply --verbose --detailed-exitcodes /tmp/apply_manifest.pp.TzBvVo
          Last 10 lines of output were:
           Info: Loading facts
           Info: Loading facts
           Info: Loading facts
           Info: Loading facts
           Info: Loading facts
           Info: Loading facts
           Info: Loading facts
           Info: Loading facts
           Error: Cannot reassign variable package_provider at /tmp/apply_manifest.pp.TzBvVo:8 on node centos-7-internap-nyj01-54597
           Error: Cannot reassign variable package_provider at /tmp/apply_manifest.pp.TzBvVo:8 on node centos-7-internap-nyj01-54597

The error is not obvious from the code.

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

I repeat here the comment in the fix:

This commit[1] in puppet-stdlib adds the package_provider. Since puppetlabs-stdlib 4.11 is pulled out of the repo[2], it has this patch. The declaration of the $package_provider variable is no longer possible. This patch removes it and uses the fact.

[1] https://github.com/puppetlabs/puppetlabs-stdlib/commits/e1a9bf506359d1e84d13b857ca6fa5e556ceeddd
[2] http://logs.openstack.org/90/304190/1/check/gate-puppet-openstacklib-puppet-beaker-rspec-centos-7/9a2160a/console.html#_2016-04-11_15_55_23_678

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-openstacklib 9.0.0 release.