duplicate definition in /modules/openstack/manifest/keystone.pp

Bug #1263886 reported by Liping Mao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-openstack
Fix Committed
Undecided
Mathieu Gagné
Havana
Fix Committed
Undecided
Mathieu Gagné

Bug Description

in modules/openstack/manifest/keystone.pp, we have the following code:
 59 class openstack::keystone (
...
 82 $enabled = true,
 83 # nova
 84 $nova = true,
...
 89 # glance
 90 $glance = true,
...
 95 # cinder
 96 $cinder = true,
...
101 # neutron
102 $neutron = true,
...
107 # ceilometer
108 $ceilometer = false,
...
113 # swift
114 $swift = false,
...
131 $glance = true,
132 $nova = true,
133 $cinder = true,
134 $neutron = true,
135 $ceilometer = false,
136 $swift = false,
...
139 $enabled = true
140 ) {

we have duplicate define for nova/glance/cinder/neutron/ceilometer/swift/enable in class openstack::keystone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-openstack (master)

Fix proposed to branch: master
Review: https://review.openstack.org/64078

Changed in puppet-openstack:
assignee: nobody → Mathieu Gagné (mgagne)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-openstack (master)

Reviewed: https://review.openstack.org/64078
Committed: https://git.openstack.org/cgit/stackforge/puppet-openstack/commit/?id=388d47bd9b58bc2259de86dfc9c23f6f3bf60583
Submitter: Jenkins
Branch: master

commit 388d47bd9b58bc2259de86dfc9c23f6f3bf60583
Author: Mathieu Gagné <email address hidden>
Date: Wed Dec 25 21:16:13 2013 -0500

    Remove duplicated parameters for keystone

    Following parameters where duplicated by mistake:
    nova, glance, cinder, neutron, ceilometer, swift, enabled.

    Change-Id: I4587ac21a3328a34971428629185bd919cfddb2b
    Closes-bug: #1263886

Changed in puppet-openstack:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-openstack (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/67335

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-openstack (stable/havana)

Reviewed: https://review.openstack.org/67335
Committed: https://git.openstack.org/cgit/stackforge/puppet-openstack/commit/?id=8130d66e957bf50b2eca276d8eafbb06e426190a
Submitter: Jenkins
Branch: stable/havana

commit 8130d66e957bf50b2eca276d8eafbb06e426190a
Author: Mathieu Gagné <email address hidden>
Date: Wed Dec 25 21:16:13 2013 -0500

    Remove duplicated parameters for keystone

    Following parameters where duplicated by mistake:
    nova, glance, cinder, neutron, ceilometer, swift, enabled.

    Change-Id: I4587ac21a3328a34971428629185bd919cfddb2b
    Closes-bug: #1263886
    (cherry picked from commit 388d47bd9b58bc2259de86dfc9c23f6f3bf60583)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.