openstack::repo::uca class breaks apt::ppa class

[Clayton O'Neill]

If the openstack::repo::uca class is included on a Ubuntu 12.04 or earlier node that also has the apt::ppa define included then a dependency cycle will be created. For example, if the following class is included:

    class landscape::facts {
      apt::ppa { 'ppa:landscape/landscape-api': }
     }

Then the following error will result:

    Error: Could not apply complete catalog: Found 1 dependency cycle:
    (Exec[add-apt-repository-ppa:landscape/landscape-api] => Exec[apt_update] => Package[python-software-properties] => Exec[add-apt-repository-ppa:landscape/landscape-api])
    Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz

This is caused by the following line:

    Exec['apt_update'] -> Package<||>

This line forces all packages to depend on the apt_update resource executing, but the apt::ppa define requires the `python-software-properties` package, and must be run before `apt_update`.

This line also introduces the potential problem that it will realize all virtual package on the node, even ones introduced outside of the openstack module, potentially causing other unexpected problems.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/77716

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/77723

[Simon Pasquier (simon-pasquier)]

Hi Clayton, are you still working on this one?