Make repositories configurable

Bug #1525385 reported by David Moreau Simard on 2015-12-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-openstack-integration
Wishlist
David Moreau Simard

Bug Description

It would be nice to be able to feed a configuration to manifests/repos.pp, this way we could run integration tests on different repositories without resorting to different branches.

Example use case: master branch points to the current-passed-ci repository (like in https://review.openstack.org/#/c/255635/) but I want to test the current repository without having to modify repos.pp.

Emilien Macchi (emilienm) wrote :

Big +1 on that. I'm also thinking at being able to disabling repo management the day we gate upstream packaging with Puppet jobs.

Example:
I submit a patch in packaging, CI is starting.
Puppet jobs start (it spawns a VM) and deploy repos "manually" (without Puppet) with a specific delorean URL. And then Puppet tasks can start.

What do you think?

Changed in puppet-openstack-integration:
status: New → Triaged
importance: Undecided → Wishlist
David Moreau Simard (dmsimard) wrote :

Either way is fine.
It's probably simpler to set up the repositories outside/before run_tests.sh and rip out the repository management from integration tests entirely.
I see value in testing that the repository classes work well, though - but perhaps that can be another test (i.e, we do integration tests on ::openstack_extras::repo::* in another scenario or something)

David Moreau Simard (dmsimard) wrote :
Changed in puppet-openstack-integration:
assignee: nobody → David Moreau Simard (dmsimard)
status: Triaged → In Progress
Alan Pevec (apevec) wrote :

@David @Emilien - review was merged, anything else left on puppet-openstack side?

David Moreau Simard (dmsimard) wrote :

Unless Emilien wants to make repositories actually configurable (which is fairly complex to do right) I settled with turning off the repository configuration so we can configure the repositories ourselves before running the integration tests. This is indeed merged and I've started working on a branch to get this going in weirdo.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers