puppet-octavia

Certificate diffs should not be shown

Bug #1804884 reported by Tobias Urdin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-octavia
Fix Released
Undecided
Tobias Urdin

Bug Description

Certificate should be considered secrets and should not output diff.
Fix this by setting show_diff to false in File resources.

OpenStack Infra (hudson-openstack)
Changed in puppet-octavia:
assignee: nobody → Tobias Urdin (tobias-urdin)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-octavia (master)

Reviewed: https://review.openstack.org/619798
Committed: https://git.openstack.org/cgit/openstack/puppet-octavia/commit/?id=45ecee290b9580c6a4b5ace72c551b63d61540b9
Submitter: Zuul
Branch: master

commit 45ecee290b9580c6a4b5ace72c551b63d61540b9
Author: Tobias Urdin <email address hidden>
Date: Fri Nov 23 21:18:38 2018 +0100

    Set show_diff to false on certificates

    Certificate should be considered secrets
    and we should not output the diffs.

    Also fixes up the testing to test all the
    parameters set on the file resources.

    Closes-Bug: 1804884
    Change-Id: I0db84f4b9d97bf22d06478ded126a1f209c9b69a

Changed in puppet-octavia:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-octavia (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/620421

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-octavia (stable/rocky)

Reviewed: https://review.openstack.org/620421
Committed: https://git.openstack.org/cgit/openstack/puppet-octavia/commit/?id=79e9f6309164bde2ef89acf4870c7dc6b484b8f9
Submitter: Zuul
Branch: stable/rocky

commit 79e9f6309164bde2ef89acf4870c7dc6b484b8f9
Author: Tobias Urdin <email address hidden>
Date: Fri Nov 23 21:18:38 2018 +0100

    Set show_diff to false on certificates

    Certificate should be considered secrets
    and we should not output the diffs.

    Also fixes up the testing to test all the
    parameters set on the file resources.

    Closes-Bug: 1804884
    Change-Id: I0db84f4b9d97bf22d06478ded126a1f209c9b69a
    (cherry picked from commit 45ecee290b9580c6a4b5ace72c551b63d61540b9)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-octavia 14.2.0

This issue was fixed in the openstack/puppet-octavia 14.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-octavia rocky-eol

This issue was fixed in the openstack/puppet-octavia rocky-eol release.

Revision history for this message
Tobias Urdin (tobias-urdin) wrote : RE:

Hello,

Kindly review the following below papers at your earliest convenience and also please provide us with your feedbackon it:

https://lojaalamar.com.br/ismu/smnsblodniiiiat

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.