puppet-openstack-beaker-centos-7 failing on puppet-nova changes

[Rajesh Tailor]

The puppet-openstack-beaker-centos-7 job is failing for puppet-nova project with below error which is not related to any of the change on which job is running.
For more detailed log, see at [1].
Also last some runs for same job for puppet-nova patches.

[1] https://zuul.opendev.org/t/openstack/build/fc3d4ba929734494b3037e7fbe693d97
[2] http://zuul.openstack.org/builds?job_name=puppet-openstack-beaker-centos-7&project=openstack%2Fpuppet-nova

2019-09-26 05:31:28.747019 | centos-7 | Failures:
2019-09-26 05:31:28.747069 | centos-7 |
2019-09-26 05:31:28.747193 | centos-7 | 1) basic nova default parameters should work with no errors
2019-09-26 05:31:28.747312 | centos-7 | Failure/Error: apply_manifest(pp, :catch_changes => true)
2019-09-26 05:31:28.747391 | centos-7 | Beaker::Host::CommandFailure:
2019-09-26 05:31:28.747492 | centos-7 | Host 'centos-70-x64' exited with 2 running:
2019-09-26 05:31:28.747655 | centos-7 | puppet apply --verbose --detailed-exitcodes /tmp/apply_manifest.pp.dR7JcT
2019-09-26 05:31:28.747746 | centos-7 | Last 10 lines of output were:
2019-09-26 05:31:28.748046 | centos-7 | Warning: This parameter is deprecated. Please add values inside Hash `wsgi_daemon_process`. at ["/etc/puppetlabs/code/modules/apache/manifests/vhost.pp", 2561]:
2019-09-26 05:31:28.748251 | centos-7 | (location: /etc/puppetlabs/code/modules/stdlib/lib/puppet/functions/deprecation.rb:34:in `deprecation')
2019-09-26 05:31:28.748446 | centos-7 | Notice: Compiled catalog for centos-7-ovh-gra1-0011868198 in environment production in 4.86 seconds
2019-09-26 05:31:28.748572 | centos-7 | Info: Applying configuration version '1569475731'
2019-09-26 05:31:28.748735 | centos-7 | Notice: /Stage[main]/Main/Nova_aggregate[test_aggregate]/metadata: metadata changed {
2019-09-26 05:31:28.748819 | centos-7 |
2019-09-26 05:31:28.748883 | centos-7 | } to {
2019-09-26 05:31:28.748959 | centos-7 | 'test' => 'property'
2019-09-26 05:31:28.749036 | centos-7 | }
2019-09-26 05:31:28.749152 | centos-7 | Notice: Applied catalog in 142.94 seconds
2019-09-26 05:31:28.749195 | centos-7 |
2019-09-26 05:31:28.749328 | centos-7 | # ./.bundled_gems/gems/beaker-2.52.0/lib/beaker/host.rb:351:in `exec'
2019-09-26 05:31:28.749496 | centos-7 | # ./.bundled_gems/gems/beaker-2.52.0/lib/beaker/dsl/helpers/host_helpers.rb:83:in `block in on'
2019-09-26 05:31:28.749661 | centos-7 | # ./.bundled_gems/gems/beaker-2.52.0/lib/beaker/shared/host_manager.rb:127:in `run_block_on'
2019-09-26 05:31:28.749829 | centos-7 | # ./.bundled_gems/gems/beaker-2.52.0/lib/beaker/dsl/patterns.rb:37:in `block_on'
2019-09-26 05:31:28.749995 | centos-7 | # ./.bundled_gems/gems/beaker-2.52.0/lib/beaker/dsl/helpers/host_helpers.rb:63:in `on'
2019-09-26 05:31:28.750205 | centos-7 | # ./.bundled_gems/gems/beaker-puppet-0.17.1/lib/beaker-puppet/helpers/puppet_helpers.rb:521:in `block in apply_manifest_on'
2019-09-26 05:31:28.750370 | centos-7 | # ./.bundled_gems/gems/beaker-2.52.0/lib/beaker/shared/host_manager.rb:127:in `run_block_on'
2019-09-26 05:31:28.750519 | centos-7 | # ./.bundled_gems/gems/beaker-2.52.0/lib/beaker/dsl/patterns.rb:37:in `block_on'
2019-09-26 05:31:28.750714 | centos-7 | # ./.bundled_gems/gems/beaker-puppet-0.17.1/lib/beaker-puppet/helpers/puppet_helpers.rb:450:in `apply_manifest_on'
2019-09-26 05:31:28.750947 | centos-7 | # ./.bundled_gems/gems/beaker-puppet-0.17.1/lib/beaker-puppet/helpers/puppet_helpers.rb:528:in `apply_manifest'
2019-09-26 05:31:28.751119 | centos-7 | # ./spec/acceptance/nova_wsgi_apache_spec.rb:39:in `block (3 levels) in <top (required)>'
2019-09-26 05:31:28.751154 | centos-7 |
2019-09-26 05:31:28.751299 | centos-7 | Finished in 15 minutes 41 seconds (files took 12.42 seconds to load)
2019-09-26 05:31:28.751361 | centos-7 | 8 examples, 1 failure
2019-09-26 05:31:28.751395 | centos-7 |
2019-09-26 05:31:28.751450 | centos-7 | Failed examples:
2019-09-26 05:31:28.751484 | centos-7 |
2019-09-26 05:31:28.751665 | centos-7 | rspec ./spec/acceptance/nova_wsgi_apache_spec.rb:7 # basic nova default parameters should work with no errors

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/685374

[Emilien Macchi (emilienm)]

https://review.opendev.org/685393

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/685393
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=edcd126dab0cd2fcca524d3838205f6c3c644257
Submitter: Zuul
Branch: master

commit edcd126dab0cd2fcca524d3838205f6c3c644257
Author: Emilien Macchi <email address hidden>
Date: Fri Sep 27 12:08:58 2019 -0400

    Fix properties in nova_aggregate provider for osc >= 4.0.0

    Similar to I6a68505d15473b140c85a199a09d2fee45864800

    Openstackclient 4.0.0 changed the way some properties are displayed
    on screen.

    Old:
    ...,"Properties"
    ...,"foo='bar'"

    New:
    ...,"Properties"
    ...,"{u'foo': u'bar'}"
    or
    ...,"{'foo': 'bar'}"

    This is breaking idempotency on the nova_aggregate provider, since it
    does not detect them correctly. This patch aims at fixing this, by
    trying to detect the new format, and using JSON parsing in that case.

    Closes-Bug: #1845616
    Depends-On: https://review.opendev.org/#/c/685537/
    Change-Id: I7e8fef9fdb913e53fa459ce09577f574fd059a13

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 15.4.0 release.