nova::compute::pci Generates Multiple Entries When hieradata nova::compute::pci::passthrough Contains JSON With Multiple Objects

[Vadim Khitrin]

When deploying with TripleO and passing the following TripleO parameter,
  NovaPCIPassthrough:
    - devname: "eth10"
      trusted: "true"
      physical_network: "sriov-1"
    - devname: "eth11"
      trusted: "true"
      physical_network: "sriov-2"

TripleO will create the following hieradata:
"nova::compute::pci::passthrough": "[{\"devname\": \"eth10\", \"physical_network\": \"sriov-1\", \"trusted\": \"true\"}, {\"devname\": \"eth11\", \"physical_network\": \"sriov-2\", \"trusted\": \"true\"}]"\

When executing /etc/puppet/modules/nova/manifests/compute/pci.pp with the hieradata mentioned above, it will result in the following 2 entries:
[pci]
passthrough_whitelist=[{"devname": "eth10", "physical_network": "sriov-1", "trusted": "true"}]
passthrough_whitelist=[{"devname": "eth11", "physical_network": "sriov-2", "trusted": "true"}]

This behaviour up to Stein release did not cause any issues.

Since Stein release, during Podman containers deployment on compute nodes, nova_wait_for_compute_service.py script runs and verifies nova.conf.
Script will fail due to multiple values of 'passthrough_whitelist' which were generated by puppet.
Refer to tripleo-heat-templates launchpad#1827775 - https://bugs.launchpad.net/tripleo/+bug/1827775

[Vadim Khitrin (vkhitrin)]

https://review.opendev.org/#/c/657673/

Verified it on fresh deployment of Stein

[Vadim Khitrin (vkhitrin)]

Will be solved by TripleO https://bugs.launchpad.net/tripleo/+bug/1827775/comments/4

No need to alter puppet-nova if it worked thus far