nova::cells depends on deprecated rabbitmq parameters

[Tom Verdaat]

The nova_cells provider still has the parameters rabbit_username, rabbit_password, rabbit_hosts, rabbit_port and rabbit_virtual_host even though these are deprecated in favor of DEFAULT/transport_url.

These rabbit_ parameters have been marked deprecated in the main nova class, but nova::cells contains a hard reference to them and uses them to call nova::manage::cells, which uses the nova_cells provider.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/612187
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=fa8660917a97e3d7700845713b213fb3c2bb05b9
Submitter: Zuul
Branch: master

commit fa8660917a97e3d7700845713b213fb3c2bb05b9
Author: Tobias Urdin <email address hidden>
Date: Sun Oct 21 17:27:14 2018 +0200

    Add cells v1 deprecation notice and remove broken code

    In Nova cells v1 has been deprecated since Ocata but we
    have no notices about it. This adds warnings about it
    being deprecated and will be removed.

    The functionality in nova::cells when passing create_cells
    parameter is broken and has therefore been removed and
    instead outputs a warning and is deprecated.

    A known issue has been added to the release notes to inform
    about this. It's probably safe to say that nobody is using it
    since it has been broken since we switched over to transport_url
    for rabbit, it's also safe to probably assume that no deployments
    that run cell v1 right now will be running a later version of Nova.

    Closes-Bug: 1687395
    Change-Id: I564fc4f43a752b051280dce095a52ca4d477fb09

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-nova 14.1.0 release.