secure_proxy_ssl_header parameter has wrong section

Bug #1588360 reported by Nikita Karpin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-nova
Fix Released
Medium
Nikita Karpin

Bug Description

Because of this bug in the documentation (https://bugs.launchpad.net/openstack-manuals/+bug/1588358) secure_proxy_ssl_header option was placed into oslo_middleware section in nova.conf, however this is incorrect because of https://github.com/openstack/nova/blob/stable/mitaka/nova/conf/wsgi.py#L30,

Moreover it was confirmed on deployed environment with openstack Mitaka that this option will not have effect if it is placed in oslo_middleware section:

2016-06-02 11:09:53.586 29779 DEBUG oslo_service.service [-] secure_proxy_ssl_header = None log_opt_values /usr/lib/python2.7/dist-packages/oslo_config/cfg.py:2517

Option should be moved to DEFAULT section.

Nikita Karpin (mkarpin)
Changed in puppet-nova:
status: New → Confirmed
assignee: nobody → Nikita Karpin (mkarpin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/324530

Changed in puppet-nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (stable/mitaka)

Reviewed: https://review.openstack.org/324530
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=5dc29fad4b3207ee360f5a465d43b19be97eb8ea
Submitter: Jenkins
Branch: stable/mitaka

commit 5dc29fad4b3207ee360f5a465d43b19be97eb8ea
Author: Mykyta Karpin <email address hidden>
Date: Thu Jun 2 16:23:17 2016 +0300

    Fix section for secure_proxy_ssl_header

    In Newton nova uses HTTPtoWSGI middleware
    and secure_proxy_ssl_header is deprecated,
    however in Mitaka secure_proxy_ssl_header is
    still used, so its section is fixed by this commit.

    Change-Id: Ic6ac9f61778f989ebbe5408b7e47176673ced427
    Related-Bug: #1576740
    Closes-Bug: #1588360

tags: added: in-stable-mitaka
Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/puppet-nova 8.2.0

This issue was fixed in the openstack/puppet-nova 8.2.0 release.

Matt Fischer (mfisch)
Changed in puppet-nova:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.