Baremetal API requres that ironic options is configured in nova.conf on nova-api node

Bug #1581040 reported by Vasyl Saienko
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
puppet-nova
Fix Released
High
Andrey Shestakov

Bug Description

At the moment ironic section is configured from nova:compute:ironic class [0].
If nova-compute and nova-api are on the different nodes. ironic section is missing in nova.conf on
nova-api node. As result baremetal api doesn't work in nova.

The proper way to fix this issue is to configure ironic options from nova:api class as well.

[0] https://github.com/openstack/puppet-nova/blob/master/manifests/compute/ironic.pp

Vasyl Saienko (vsaienko)
tags: added: ironic
Revision history for this message
Emilien Macchi (emilienm) wrote :

it's the same issue as vncproxy, I prefer the option of using a class, let's say nova::ironic::comon (we could also have later nova::ironic::compute and nova::ironic::api for specific options), and include the common classe (+ the specific classes if needed) in nova::compute and nova::api.

What do you think?

Changed in puppet-nova:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Denis Egorenko (degorenko) wrote :

+1 for Emilien suggestion

Revision history for this message
Vasyl Saienko (vsaienko) wrote :

Sounds good

Changed in puppet-nova:
assignee: nobody → Andrey Shestakov (ashestakov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/317593

Changed in puppet-nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (master)

Reviewed: https://review.openstack.org/317593
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=2f0f24c5e7c75d160452020f0445dea122dd1ad5
Submitter: Jenkins
Branch: master

commit 2f0f24c5e7c75d160452020f0445dea122dd1ad5
Author: Andrey Shestakov <email address hidden>
Date: Tue May 17 18:49:51 2016 +0300

    Implement nova::ironic::common class

    This change introduces new class nova::ironic::common which adds common
    Ironic related parameters to nova.conf required for nova-api and nova-compute.

    Change-Id: Ia878d19cffd833e9bf95d1b26ff0c2b6c02370d0
    Closes-bug: #1581040

Changed in puppet-nova:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/319344

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (stable/mitaka)

Reviewed: https://review.openstack.org/319344
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=abb20ed24542350bc062c8295b7e9c596b2a4afb
Submitter: Jenkins
Branch: stable/mitaka

commit abb20ed24542350bc062c8295b7e9c596b2a4afb
Author: Andrey Shestakov <email address hidden>
Date: Tue May 17 18:49:51 2016 +0300

    Implement nova::ironic::common class

    This change introduces new class nova::ironic::common which adds common
    Ironic related parameters to nova.conf required for nova-api and nova-compute.

    Change-Id: Ia878d19cffd833e9bf95d1b26ff0c2b6c02370d0
    Closes-bug: #1581040
    (cherry picked from commit 2f0f24c5e7c75d160452020f0445dea122dd1ad5)

tags: added: in-stable-mitaka
Revision history for this message
Thierry Carrez (ttx) wrote : Fix included in openstack/puppet-nova 8.1.0

This issue was fixed in the openstack/puppet-nova 8.1.0 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/puppet-nova 9.0.0

This issue was fixed in the openstack/puppet-nova 9.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.