Hello there,
While setting up Nova Compute + RBD, we have to provide the libvirt_rbd_secret_uuid value.
This value has to be defined in nova.conf, and then a virsh secret has to be created and the virsh value for this secret has to be set.
The first two steps works well but the last step is never executed. Why ? That is quite simple.
The 3rd step is defined in rbd.pp, lines 78 to 82:
exec { 'set-secret-value virsh':
command => "/usr/bin/virsh secret-set-value --secret $(cat /etc/nova/virsh.secret) --base64 $(ceph auth get-key ${rbd_keyring})",
unless => "/usr/bin/virsh secret-list | grep ${libvirt_rbd_secret_uuid}",
require => Exec['get-or-set virsh secret']
}
We can see that Puppet will set the value, unless the secret-list returns our secret. And it will Always return something, because the step 2 created it. The appropriate unless command should instead verify if a value has been set to this secret :
exec { 'set-secret-value virsh':
command => "/usr/bin/virsh secret-set-value --secret $(cat /etc/nova/virsh.secret) --base64 $(ceph auth get-key ${rbd_keyring})",
unless => "/usr/bin/virsh secret-get-value ${libvirt_rbd_secret_uuid} | grep $(ceph auth get-key ${rbd_keyring})",
require => Exec['get-or-set virsh secret']
}
Fix proposed to branch: master
Review: https:/