puppet-nova

Unit-tests broken due to an update of rspec-puppet (2.0.0)

Bug #1417604 reported by Sebastien Badia
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-nova
Fix Released
Critical
Sebastien Badia
puppet-nova 6.0.0 "6.0.0"
Juno
Fix Released
Undecided
Unassigned
puppet-nova 5.1.0 "5.1.0"

Bug Description

rspec-puppet (2.0.0) was released yesterday (https://github.com/rodjek/rspec-puppet/commit/8459e14807977244c00bdbcf190062c529b63474) this new version broke puppet-openstack unit tests (undefined method `resource') http://logs.openstack.org/45/105245/6/check/gate-puppet-nova-puppet-unit-3.3/3682541/console.html

as talked on #puppet-openstack and #openstack-infra, we decided to pin rspec-puppet to 1.0.1 and in a second time to update your specs to 2.0.0 and rspec 3.x

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/152542

Revision history for this message
Sebastien Badia (sbadia) wrote :

In order to track all patchs https://review.openstack.org/#/q/status:open+branch:master+topic:bug/1417604,n,z
Or on trello! https://trello.com/c/OlKf5Jgg/3-pin-rspec-puppet-to-1-0-1

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (master)

Reviewed: https://review.openstack.org/152542
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=ad97aa23723ad93886da085e26a712024be79823
Submitter: Jenkins
Branch: master

commit ad97aa23723ad93886da085e26a712024be79823
Author: Sebastien Badia <email address hidden>
Date: Tue Feb 3 15:32:20 2015 +0100

    spec: pin rspec-puppet to 1.0.1

    rspec-puppet (2.0.0) was released yesterday[1], this new version broke
    puppet-openstack unit tests (undefined method `resource')[2] as talked on
    and in a second time to update your specs to 2.0.0 and rspec 3.x`)

    [1] https://github.com/rodjek/rspec-puppet/commit/8459e14807977244c00bdbcf190062c529b63474
    [2] http://logs.openstack.org/45/105245/6/check/gate-puppet-nova-puppet-unit-3.3/3682541/console.html

    Change-Id: I6b5ef612b0a0911bb52622c65560afec713d45c0
    Partial-bug: #1417604

Sebastien Badia (sbadia)
Changed in puppet-nova:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (stable/juno)

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/155321

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (stable/juno)

Reviewed: https://review.openstack.org/155321
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=9a0a5294fc9d54634a6d90da157492d0943ae3c1
Submitter: Jenkins
Branch: stable/juno

commit 9a0a5294fc9d54634a6d90da157492d0943ae3c1
Author: Sebastien Badia <email address hidden>
Date: Tue Feb 3 15:32:20 2015 +0100

    spec: pin rspec-puppet to 1.0.1

    rspec-puppet (2.0.0) was released yesterday[1], this new version broke
    puppet-openstack unit tests (undefined method `resource')[2] as talked on
    and in a second time to update your specs to 2.0.0 and rspec 3.x`)

    [1] https://github.com/rodjek/rspec-puppet/commit/8459e14807977244c00bdbcf190062c529b63474
    [2] http://logs.openstack.org/45/105245/6/check/gate-puppet-nova-puppet-unit-3.3/3682541/console.html

    Change-Id: I6b5ef612b0a0911bb52622c65560afec713d45c0
    Partial-bug: #1417604
    (cherry picked from commit ad97aa23723ad93886da085e26a712024be79823)

tags: added: in-stable-juno
Mathieu Gagné (mgagne)
Changed in puppet-nova:
milestone: none → 6.0.0
Mathieu Gagné (mgagne)
Changed in puppet-nova:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.