Catalog compilation fails when $configure_endpoint is set to false

[Risto Laurikainen]

In the keystone::auth class when $configure_endpoint is set to false, a keystone_endpoint will not be added to the catalog. However, a relationship between the non-existent keystone_endpoint and the service being managed is added regardless, causing catalog compilation to fail as the keystone_endpoint required by the notification relationship does not exist.

This can be fixed by moving the Keystone_endpoint ~> Service part inside the if-block for $configure_endpoint.

It looks like there is no spec test where $configure_endpoint is set to false. That should probably also be added.

[Matt Fischer (mfisch)]

This code was refactored for Kilo on master, can you please confirm that it's still an issue?

[Risto Laurikainen (risto-laurikainen)]

Based on looking at the code this is still an issue. I haven't yet tested the refactored code (I'll probably start doing so next week), but it seems to me that if you set $configure_endpoint as false for any of the keystone::auth classes, then ensure_resource is not called in keystone::resource::service_identity and no keystone_endpoint resource is created. If no keystone_endpoint resource is created, then that will still break because this relationship on keystone::auth is used anyway no matter what $configure_endpoint is set to: "Keystone_endpoint["${region}/${real_service_name}"] ~> Service"

[Risto Laurikainen (risto-laurikainen)]

I confirmed this for puppet-neutron on a test system today. The code is exactly the same for the rest of the modules, so they have this problem as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/156999

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/157002

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/157009

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157002
Committed: https://git.openstack.org/cgit/stackforge/puppet-nova/commit/?id=927353ddf53103564737d0bf06d254564ee0eba0
Submitter: Jenkins
Branch: master

commit 927353ddf53103564737d0bf06d254564ee0eba0
Author: Risto Laurikainen <email address hidden>
Date: Wed Feb 18 14:07:36 2015 +0000

    Fix catalog compilation when not configuring endpoint

    Previously when you set $configure_endpoint to false and did not have a
    keystone_endpoint resource with the same name as is defined by
    nova::keystone::auth, the catalog would not be compiled. This was
    because a relationship was being established where one resource in the
    relationship didn't exist.

    This changes this so that the relationship involving the Keystone
    endpoint is only defined if $configure_endpoint is set to true.

    Change-Id: Ief2ea40d0e4f31e18ba4b1230c5879909a1cfe46
    Closes-Bug: 1368686

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/157009
Committed: https://git.openstack.org/cgit/stackforge/puppet-glance/commit/?id=ee0549f15dd6b9442b559ca363b934b60588b7e2
Submitter: Jenkins
Branch: master

commit ee0549f15dd6b9442b559ca363b934b60588b7e2
Author: Risto Laurikainen <email address hidden>
Date: Wed Feb 18 14:14:17 2015 +0000

    Fix catalog compilation when not configuring endpoint

    Previously when you set $configure_endpoint to false and did not have a
    keystone_endpoint resource with the same name as is defined by
    glance::keystone::auth, the catalog would not be compiled. This was
    because a relationship was being established where one resource in the
    relationship didn't exist.

    This changes this so that the relationship involving the Keystone
    endpoint is only defined if $configure_endpoint is set to true.

    Also, the test for when $configure_endpoint is false was set to check
    for an endpoint that doesn't get created even if $configure_endpoint is
    true. Fixed so that it checks for an endpoint that has the correct name
    (the same as when using the default values to call the class).

    Change-Id: I6631a656a888d0df7ab173705bea0598bd2b2f58
    Closes-Bug: 1368686

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/156999
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=73d7599665b6d499280d29b5f59c26124ad5e643
Submitter: Jenkins
Branch: master

commit 73d7599665b6d499280d29b5f59c26124ad5e643
Author: Risto Laurikainen <email address hidden>
Date: Wed Feb 18 13:55:58 2015 +0000

    Fix catalog compilation when not configuring endpoint

    Previously when you set $configure_endpoint to false and did not have a
    keystone_endpoint resource with the same name as is defined by
    neutron::keystone::auth, the catalog would not be compiled. This was
    because a relationship was being established where one resource in the
    relationship didn't exist.

    This changes this so that the relationship involving the Keystone
    endpoint is only defined if $configure_endpoint is set to true.

    Change-Id: I710da4811f456410239efb1487e3407a42686a2b
    Closes-Bug: 1368686

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/juno
Review: https://review.openstack.org/187335

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/187335
Committed: https://git.openstack.org/cgit/stackforge/puppet-glance/commit/?id=d64e9876478f74f753cd53447beba04d94b2925b
Submitter: Jenkins
Branch: stable/juno

commit d64e9876478f74f753cd53447beba04d94b2925b
Author: Risto Laurikainen <email address hidden>
Date: Wed Feb 18 14:14:17 2015 +0000

    Fix catalog compilation when not configuring endpoint

    Previously when you set $configure_endpoint to false and did not have a
    keystone_endpoint resource with the same name as is defined by
    glance::keystone::auth, the catalog would not be compiled. This was
    because a relationship was being established where one resource in the
    relationship didn't exist.

    This changes this so that the relationship involving the Keystone
    endpoint is only defined if $configure_endpoint is set to true.

    Also, the test for when $configure_endpoint is false was set to check
    for an endpoint that doesn't get created even if $configure_endpoint is
    true. Fixed so that it checks for an endpoint that has the correct name
    (the same as when using the default values to call the class).

    Change-Id: I6631a656a888d0df7ab173705bea0598bd2b2f58
    Closes-Bug: 1368686
    (cherry-picked from commit ee0549f15dd6b9442b559ca363b934b60588b7e2)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/190308

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/190308
Committed: https://git.openstack.org/cgit/openstack/puppet-trove/commit/?id=39867dcd31cacf6882ede22fb25d9cd62aaf1a40
Submitter: Jenkins
Branch: master

commit 39867dcd31cacf6882ede22fb25d9cd62aaf1a40
Author: Emilien Macchi <email address hidden>
Date: Wed Jun 10 15:24:07 2015 -0400

    Fix catalog compilation when not configuring endpoint

    Previously when you set $configure_endpoint to false and did not have a
    keystone_endpoint resource with the same name as is defined by
    neutron::keystone::auth, the catalog would not be compiled. This was
    because a relationship was being established where one resource in the
    relationship didn't exist. This changes this so that the relationship
    involving the Keystone endpoint is only defined if $configure_endpoint
    is set to true.

    Change-Id: I1ee51f33ffd1bf20578cd56120ee5be8e6fa0133
    Co-Authored-By: Risto Laurikainen <email address hidden>
    Co-Authored-By: Gael Chamoulaud <email address hidden>
    Closes-Bug: 1368686

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/207435

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/207435
Committed: https://git.openstack.org/cgit/openstack/puppet-trove/commit/?id=93bb2f6d40b87fdc5be9971f614716a529fb1e49
Submitter: Jenkins
Branch: stable/kilo

commit 93bb2f6d40b87fdc5be9971f614716a529fb1e49
Author: Emilien Macchi <email address hidden>
Date: Wed Jun 10 15:24:07 2015 -0400

    Fix catalog compilation when not configuring endpoint

    Previously when you set $configure_endpoint to false and did not have a
    keystone_endpoint resource with the same name as is defined by
    neutron::keystone::auth, the catalog would not be compiled. This was
    because a relationship was being established where one resource in the
    relationship didn't exist. This changes this so that the relationship
    involving the Keystone endpoint is only defined if $configure_endpoint
    is set to true.

    Change-Id: I1ee51f33ffd1bf20578cd56120ee5be8e6fa0133
    Co-Authored-By: Risto Laurikainen <email address hidden>
    Co-Authored-By: Gael Chamoulaud <email address hidden>
    Closes-Bug: 1368686
    (cherry picked from commit 39867dcd31cacf6882ede22fb25d9cd62aaf1a40)