Incorrect dependency on puppetlabs-rabbitmq

Bug #1350966 reported by Florian Haas
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-nova
Fix Released
Low
Richard Raseley

Bug Description

This module depends on:
dependency 'puppetlabs/rabbitmq', '>=2.0.2 <4.0.0'

... but it uses rabbitmq::server, which was removed in 3.0.0 and reinstatated in 4.0.0.

So this dependency should be changed to
dependency 'puppetlabs/rabbitmq', '>=2.0.2 <3.0.0'

However, this would the module uninstallable with puppetlabs-openstack, which itself has an incompatible dependency:
dependency 'puppetlabs/rabbitmq', '>=3.0.0 <4.0.0'

Revision history for this message
Chris Hoge (hoge) wrote :

Hi Florian,

The nova api was modified to allow either using the 2/4 api or the 3 api (choosing between ::rabbitmq or ::rabbitmq::server as the rabbit class). On the puppetlabs-openstack module I explicitly use the ::rabbitmq class. Maybe the solution would be to modify all of the apis to use >=4.0.0 < 5.0.0.

I wonder how many users are deploying with older versions of RabbitMQ.

Changed in puppet-nova:
status: New → Confirmed
assignee: nobody → Richard Raseley (richard-raseley)
Revision history for this message
Alex Schultz (alex-schultz) wrote :

Hey Richard,

Based on our the puppet openstack meeting[0] this week, we talked about deprecating the rabbitmq server configuration out of puppet-nova as that should be handled elsewhere. This should clear up the dependency resolution issues. In the mean time is there a version that would be compatible for everyone?

[0] http://eavesdrop.openstack.org/meetings/puppet_openstack/2015/puppet_openstack.2015-09-01-15.00.html

Revision history for this message
Richard Raseley (richard-raseley) wrote :

At this point, puppetlabs-openstack is all but abandoned. We've yet to finalize our strategy to replace / supplement the value it provided.

If you need to break it in order to keep the core modules in an orderly state, I say go-ahead.

That being said, I don't actually know the actual requirements in puppetlabs-openstack for rabbitmq are, so it might be a trivial fix.

Revision history for this message
Cody Herriges (ody-cat) wrote :

This was fixed in stable/mitaka which was pushed to the forge, the place where these version ranges matter the most.

Changed in puppet-nova:
importance: Undecided → Low
Revision history for this message
Matt Fischer (mfisch) wrote :

Can we mark it as Fix Released then please?

Changed in puppet-nova:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.