neutron_subnet does not handle empty dns servers, allocation pools and also specific host routes

[Lukas Bezdicka]

neutron subnet was expanded with ability to to set and update parameters like
specifing dns servers, allocation pools and also specific host routes.
Sadly it introduced issue when calling neutron_subnet without specifying
values for these parameters.

This issue generates error:
Notice: /Stage[main]/Openstack::Provision/Neutron_network[public]/ensure: created
Error: Could not set 'present' on ensure: undefined method `[]' for nil:NilClass at 173:/var/tmp/packstack/9d9ca5a840ae48d684cb1537a0cf4142/modules/openstack/manifests/provision.pp
Error: Could not set 'present' on ensure: undefined method `[]' for nil:NilClass at 173:/var/tmp/packstack/9d9ca5a840ae48d684cb1537a0cf4142/modules/openstack/manifests/provision.pp
Wrapped exception:
undefined method `[]' for nil:NilClass
Error: /Stage[main]/Openstack::Provision/Neutron_subnet[public_subnet]/ensure: change from absent to present failed: Could not set 'present' on ensure: undefined method `[]' for nil:NilClass at 173:/var/tmp/packstack/9d9ca5a840ae48d684cb1537a0cf4142/modules/openstack/manifests/provision.pp
Notice: /Stage[main]/Openstack::Provision/Neutron_l3_ovs_bridge[br-ex]: Dependency Neutron_subnet[public_subnet] has failures: true
Warning: /Stage[main]/Openstack::Provision/Neutron_l3_ovs_bridge[br-ex]: Skipping because of failed dependencies
Notice: /Stage[main]/Openstack::Provision/Keystone_tenant[demo]/ensure: created
Notice: /Stage[main]/Openstack::Provision/Neutron_router[router1]: Dependency Neutron_subnet[public_subnet] has failures: true
Warning: /Stage[main]/Openstack::Provision/Neutron_router[router1]: Skipping because of failed dependencies
Notice: /Stage[main]/Openstack::Provision/Neutron_network[private]/ensure: created
Error: Could not set 'present' on ensure: undefined method `[]' for nil:NilClass at 183:/var/tmp/packstack/9d9ca5a840ae48d684cb1537a0cf4142/modules/openstack/manifests/provision.pp
Error: Could not set 'present' on ensure: undefined method `[]' for nil:NilClass at 183:/var/tmp/packstack/9d9ca5a840ae48d684cb1537a0cf4142/modules/openstack/manifests/provision.pp
Wrapped exception:
undefined method `[]' for nil:NilClass
Error: /Stage[main]/Openstack::Provision/Neutron_subnet[private_subnet]/ensure: change from absent to present failed: Could not set 'present' on ensure: undefined method `[]' for nil:NilClass at 183:/var/tmp/packstack/9d9ca5a840ae48d684cb1537a0cf4142/modules/openstack/manifests/provision.pp
Error: Could not prefetch neutron_router_interface provider 'neutron': undefined method `[]' for nil:NilClass
Notice: /Stage[main]/Openstack::Provision/Neutron_router_interface[router1:private_subnet]: Dependency Neutron_subnet[public_subnet] has failures: true
Notice: /Stage[main]/Openstack::Provision/Neutron_router_interface[router1:private_subnet]: Dependency Neutron_subnet[private_subnet] has failures: true
Warning: /Stage[main]/Openstack::Provision/Neutron_router_interface[router1:private_subnet]: Skipping because of failed dependencies

[Openstack Gerrit (openstack-gerrit)]

Reviewed: https://review.openstack.org/88305
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=78428c844f73bf585a8f8a3bdf615ba2a0e8983b
Submitter: Jenkins
Branch: master

commit 78428c844f73bf585a8f8a3bdf615ba2a0e8983b
Author: Lukas Bezdicka <email address hidden>
Date: Thu Apr 17 15:48:40 2014 +0200

    Fix neutron subnets with empty values.

    Subnet was expended with ability to set and update parameters like
    specifing dns servers, allocation pools and also specific host routes.
    Sadly it introduced issue when calling neutron_subnet without specifying
    values for these parameters.
    Closes-Bug: #1312628

    Change-Id: Id1207ab793fc65c43c10afcfe2271e2c02a912d3

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/110281

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/110281
Committed: https://git.openstack.org/cgit/stackforge/puppet-neutron/commit/?id=c21db12f579ace1cea5727b37af64f4534f48064
Submitter: Jenkins
Branch: stable/havana

commit c21db12f579ace1cea5727b37af64f4534f48064
Author: Lukas Bezdicka <email address hidden>
Date: Thu Apr 17 15:48:40 2014 +0200

    Fix neutron subnets with empty values.

    Subnet was expended with ability to set and update parameters like
    specifing dns servers, allocation pools and also specific host routes.
    Sadly it introduced issue when calling neutron_subnet without specifying
    values for these parameters.
    Closes-Bug: #1312628

    Change-Id: Id1207ab793fc65c43c10afcfe2271e2c02a912d3
    (cherry picked from commit 78428c844f73bf585a8f8a3bdf615ba2a0e8983b)