neutron_network provider_segmentation_id broken

[Tim Bishop]

On Ubuntu 22.04 with Neutron from 2024.1 and puppet-neutron version 24.0.0 I get the following error when using the provider_segmentation_id option to neutron_network:

Error: Execution of '/usr/bin/openstack network create --format shell vlan44 --share --project=admin --provider-network-type=vlan --provider-physical-network=physnet1 --provider-segmentation-id=44' returned 2: usage: openstack network create [-h] [-f {json,shell,table,value,yaml}]
                                [-c COLUMN] [--noindent] [--prefix PREFIX]
                                [--max-width <integer>] [--fit-width]
                                [--print-empty]
                                [--extra-property type=<property_type>,name=<property_name>,value=<property_value>]
                                [--share | --no-share] [--enable | --disable]
                                [--project <project>]
                                [--description <description>] [--mtu <mtu>]
                                [--project-domain <project-domain>]
                                [--availability-zone-hint <availability-zone>]
                                [--enable-port-security | --disable-port-security]
                                [--external | --internal]
                                [--default | --no-default]
                                [--qos-policy <qos-policy>]
                                [--transparent-vlan | --no-transparent-vlan]
                                [--provider-network-type <provider-network-type>]
                                [--provider-physical-network <provider-physical-network>]
                                [--provider-segment <provider-segment>]
                                [--dns-domain <dns-domain>]
                                [--tag <tag> | --no-tag]
                                <name>
openstack network create: error: unrecognized arguments: --provider-segmentation-id=44

The fix is pretty straightforward:

diff -ruN neutron/lib/puppet/provider/neutron_network/openstack.rb.orig neutron/lib/puppet/provider/neutron_network/openstack.rb
--- neutron/lib/puppet/provider/neutron_network/openstack.rb.orig 2024-06-17 14:49:49.780655809 +0100
+++ neutron/lib/puppet/provider/neutron_network/openstack.rb 2024-07-04 12:35:22.133007670 +0100
@@ -97,7 +97,7 @@

     if @resource[:provider_segmentation_id]
       opts << \
- "--provider-segmentation-id=#{@resource[:provider_segmentation_id]}"
+ "--provider-segment=#{@resource[:provider_segmentation_id]}"
     end

     if @resource[:router_external] == 'True'

But obviously not backwards compatible.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-neutron/+/923610

[Takashi Kajinami (kajinamit)]

The option was added a while back https://review.opendev.org/c/openstack/python-openstackclient/+/303224

I think this is the regression we introduced when replacing neutron CLI by openstack CLI... so we don't have to care about backwords compatibility and can just replace the wrong option.