neutron::agents::dhcp should fail when only enable_metadata_network=true is set

[Takashi Kajinami]

[DEFAULT] enable_metadata_network = true requires one of enable_isolated_metadata or force_metadata is enabled.

By default, enabled_isolated_metadata is set to false, while force_metadata is not defined in config file(because the parameter is internally set to $::os_service_default), which is effectively same as false.

Thus, when only enable_metadata_network = true is defined, the class should fail.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-neutron/+/836242

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-neutron/+/836242
Committed: https://opendev.org/openstack/puppet-neutron/commit/9be4bfcc2f50aa37505eb171afac20f8c5f0e2c3
Submitter: "Zuul (22348)"
Branch: master

commit 9be4bfcc2f50aa37505eb171afac20f8c5f0e2c3
Author: Takashi Kajinami <email address hidden>
Date: Sun Apr 3 22:50:33 2022 +0900

    dhcp-agent: Hard-code default of [DEFAULT] force_metadata

    ... so that the class can validate the metadata configurations
    correctly.

    This change also enforces enable_* parameters are set to boolean values
    because the current validation logic works as expected only for
    booleans.

    Closes-Bug: #1967678
    Change-Id: I23dfd99ac12ba177828ecb1f0caa8a0206411663

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 21.0.0 release.