Original downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1807602
Depending on how NeutronBridgeMappings parameter is defined in heat templates, it can in some cases trigger the error:
puppet-user: Error: Evaluation Error: Error while evaluating a Function Call, 'join' parameter 'arg' expects an Array value, got String (file: /etc/puppet/modules/neutron/manifests/agents/ml2/ovs.pp, line: 271, column: 19) on node central-controller0-1.redhat.local", "+ rc=1", "+ '[' False = false ']'", "+ set -e", "+ '[' 1 -ne 2 -a 1 -ne 0 ']'", "+ exit 1", " attempt(s): 3", "2020-02-26 17:12:14,165 INFO: 39551 -- Removing container: container-puppet-neutron", "2020-02-26 17:12:14,323 WARNING: 39551 -- Retrying running container: neutron", "2020-02-26 17:12:14,323 ERROR: 39551 -- Failed running container for neutron", "2020-02-26 17:12:14,323 INFO: 39551 -- Finished processing puppet configs for neutron", "2020-02-26 17:12:14,324 ERROR: 39550 -- ERROR configuring neutron"]}
This has to do with the fact that NeutronBridgeMappings is being defined as a role specific parameter as opposed to the usual method. It seems there is a difference between how heat processes the values of a heat parameter versus the one provided through role specific data. For example:
parameter_defaults:
NeutronBridgeMappings: "site1:br-link1"
versus
parameter_defaults:
Controller0Parameters:
NeutronBridgeMappings: "leaf0:br-ex"
lead to different results in the hieradata.
This would apply anywhere we use role specific data and rely on heat to do "something" type related when constructing the config data
We should handle this possible case in puppet module
Fix proposed to branch: master
Review: https:/