unsetting tunnel types does not remove tunnel types from existing config

[Brent Eagles]

original report: https://bugzilla.redhat.com/show_bug.cgi?id=1717114

When switching from tunnel_types: 'vxlan' to tunnel_types: '' in a cloud that was already deployed, puppet does not unset `agent/tunnel_types`, but it does unset `local_ip`. This leads to a runtime error:

ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent [-] Tunneling can't be enabled with invalid local_ip 'None'. IP couldn't be found on this host's interfaces.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/664419

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/664419
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=6c34ce2a42ae8c445a1fbe14ab18d4ee59e09c9b
Submitter: Zuul
Branch: master

commit 6c34ce2a42ae8c445a1fbe14ab18d4ee59e09c9b
Author: Brent Eagles <email address hidden>
Date: Mon Jun 10 15:54:23 2019 -0230

    Ensure tunnel types are absent if not configured

    This patch fixes a bug where updating a configuration wouldn't remove
    agent/tunnel_types configuration when required.

    Change-Id: I8248ad80e6ff88aec252919fa687018bda78a60b
    Closes-Bug: #1832251

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/666403

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/666406

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/666407

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666407
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=fedd77e759f42dd086975e285f2c7bcac419d939
Submitter: Zuul
Branch: stable/queens

commit fedd77e759f42dd086975e285f2c7bcac419d939
Author: Brent Eagles <email address hidden>
Date: Mon Jun 10 15:54:23 2019 -0230

    Ensure tunnel types are absent if not configured

    This patch fixes a bug where updating a configuration wouldn't remove
    agent/tunnel_types configuration when required.

    Conflicts:
      spec/classes/neutron_agents_ml2_ovs_spec.rb

    Change-Id: I8248ad80e6ff88aec252919fa687018bda78a60b
    Closes-Bug: #1832251
    (cherry picked from commit 6c34ce2a42ae8c445a1fbe14ab18d4ee59e09c9b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666406
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=f55b869b508494328b3cbee39c4a2451d912f170
Submitter: Zuul
Branch: stable/rocky

commit f55b869b508494328b3cbee39c4a2451d912f170
Author: Brent Eagles <email address hidden>
Date: Mon Jun 10 15:54:23 2019 -0230

    Ensure tunnel types are absent if not configured

    This patch fixes a bug where updating a configuration wouldn't remove
    agent/tunnel_types configuration when required.

    Conflicts:
      spec/classes/neutron_agents_ml2_ovs_spec.rb

    Change-Id: I8248ad80e6ff88aec252919fa687018bda78a60b
    Closes-Bug: #1832251
    (cherry picked from commit 6c34ce2a42ae8c445a1fbe14ab18d4ee59e09c9b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 15.1.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666403
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=5c261512c50da865efbceaa74e370cbe96fb7215
Submitter: Zuul
Branch: stable/stein

commit 5c261512c50da865efbceaa74e370cbe96fb7215
Author: Brent Eagles <email address hidden>
Date: Mon Jun 10 15:54:23 2019 -0230

    Ensure tunnel types are absent if not configured

    This patch fixes a bug where updating a configuration wouldn't remove
    agent/tunnel_types configuration when required.

    Change-Id: I8248ad80e6ff88aec252919fa687018bda78a60b
    Closes-Bug: #1832251
    (cherry picked from commit 6c34ce2a42ae8c445a1fbe14ab18d4ee59e09c9b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron stein-eol release.