Cisco Nexus config template - update config & remove deprecated features

[Carol Bouchard]

The Nexus driver has made multiple configuration changes mostly removing multiple deprecation features. This changes update puppet-neutron to accomodate those recent changes. Change include:

* https_verify now defaults to True
* intcfg.portchannel replaced by intfcfg_portchannel
* Remove ncclient driver which causes the following config parameters to be removed.
  - ssh_port
  - host_key_checks
  - never_cache_ssh_connectino
  - nexus_driver - now always restapi
  - persistent_switch_config
* Only 'host_ports_mapping' config exist. Can no longer just list host name following by interfaces.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/606958

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/606958
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a425a6f1ff1833da0ec5f42c7ca3f9ad952b54bf
Submitter: Zuul
Branch: master

commit a425a6f1ff1833da0ec5f42c7ca3f9ad952b54bf
Author: Carol Bouchard <email address hidden>
Date: Mon Oct 1 10:05:41 2018 -0400

    CiscoNexus: Update and Remove deprecated vars

    Update and Remove deprecated variables from Cisco Nexus Config.
    * Deprecated variables include vlan_name_prefix, svi_round_robin,
      provider_vlan_name_prefix, persistent_switch_config,
      never_cache_ssh_connection, ssh_port, switch_replay_count,
      nexus_driver, and host_key_checks.
    * Change config replay to on by defaulting switch_heartbeat_time=30.
    * Replaced method of configurating host_ports_mapping config.

    Depends-On: Iee2f869c4054f1120d224994aba8c827f981e6c0
    Change-Id: Ibda17afdcf7a6748f15390fd8a0a8b70bb6dfc2b
    Closes-bug: #1793381

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 10.3.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/699420

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699420
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bcba626d3b868457d34aa418eca6b3cf4792356a
Submitter: Zuul
Branch: stable/queens

commit bcba626d3b868457d34aa418eca6b3cf4792356a
Author: Carol Bouchard <email address hidden>
Date: Mon Oct 1 10:05:41 2018 -0400

    CiscoNexus: Update and Remove deprecated vars

    Update and Remove deprecated variables from Cisco Nexus Config.
    * Deprecated variables include vlan_name_prefix, svi_round_robin,
      provider_vlan_name_prefix, persistent_switch_config,
      never_cache_ssh_connection, ssh_port, switch_replay_count,
      nexus_driver, and host_key_checks.
    * Change config replay to on by defaulting switch_heartbeat_time=30.
    * Replaced method of configurating host_ports_mapping config.

    Depends-On: Iee2f869c4054f1120d224994aba8c827f981e6c0
    Change-Id: Ibda17afdcf7a6748f15390fd8a0a8b70bb6dfc2b
    Closes-bug: #1793381
    (cherry picked from commit a425a6f1ff1833da0ec5f42c7ca3f9ad952b54bf)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

[Takashi Kajinami (kajinamit)]

I checked the related tripleo patch but seems the issue with puppet-neutron as fixed by https://review.opendev.org/q/Iee2f869c4054f1120d224994aba8c827f981e6c0