Cisco nexus config template - update config & remove deprecated features

[Carol Bouchard]

The Nexus driver has made multiple configuration changes mostly removing multiple deprecation features. This changes update puppet-neutron to accomodate those recent changes. Change include:

* https_verify now defaults to True
* intcfg.portchannel replaced by intfcfg_portchannel
* Remove ncclient driver which causes the following config parameters to be removed.
  - ssh_port
  - host_key_checks
  - never_cache_ssh_connectino
  - nexus_driver - now always restapi
  - persistent_switch_config
* Only 'host_ports_mapping' config exist. Can no longer just list host name following by interfaces.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/606957

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/607531

[OpenStack Infra (hudson-openstack)]

Change abandoned by Carol Bouchard (<email address hidden>) on branch: master
Review: https://review.openstack.org/607531
Reason: not needed

[OpenStack Infra (hudson-openstack)]

Change abandoned by Carol Bouchard (<email address hidden>) on branch: master
Review: https://review.openstack.org/607531
Reason: no longer needed.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/606957
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=f45169f38db4333d60841136fe3fab951221eeb6
Submitter: Zuul
Branch: master

commit f45169f38db4333d60841136fe3fab951221eeb6
Author: Carol Bouchard <email address hidden>
Date: Mon Oct 1 10:03:49 2018 -0400

    CiscoNexus: Update and Remove deprecated vars

    Update and Remove deprecated variables from Cisco Nexus Config.
    * Deprecated variables include vlan_name_prefix, svi_round_robin,
      provider_vlan_name_prefix, persistent_switch_config,
      never_cache_ssh_connection, ssh_port, switch_replay_count,
      nexus_driver, and host_key_checks.
    * Change config replay to on by defaulting switch_heartbeat_time=30.
    * Replaced method of configurating host_ports_mapping config.

    Change-Id: Iee2f869c4054f1120d224994aba8c827f981e6c0
    Closes-bug: #1793379

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 14.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/699417

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/699418

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699417
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=f1ac3e32ea5efc5ab054caeed3578277581a0cba
Submitter: Zuul
Branch: stable/rocky

commit f1ac3e32ea5efc5ab054caeed3578277581a0cba
Author: Emilien Macchi <email address hidden>
Date: Tue Dec 17 15:57:57 2019 -0500

    CiscoNexus: Update and Remove deprecated vars

    Backward compatible backport (modified by hand).

    Update and Remove deprecated variables from Cisco Nexus Config.
    * Deprecated variables include vlan_name_prefix, svi_round_robin,
      provider_vlan_name_prefix, persistent_switch_config,
      never_cache_ssh_connection, ssh_port, switch_replay_count,
      nexus_driver, and host_key_checks.
    * Change config replay to on by defaulting switch_heartbeat_time=30.
    * Replaced method of configurating host_ports_mapping config.

    Change-Id: Iee2f869c4054f1120d224994aba8c827f981e6c0
    Closes-bug: #1793379
    (cherry picked from commit f45169f38db4333d60841136fe3fab951221eeb6)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699418
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=b0196fd0e4029bee0fc1431638f4db442b3d9b83
Submitter: Zuul
Branch: stable/queens

commit b0196fd0e4029bee0fc1431638f4db442b3d9b83
Author: Emilien Macchi <email address hidden>
Date: Tue Dec 17 15:57:57 2019 -0500

    CiscoNexus: Update and Remove deprecated vars

    Backward compatible backport (modified by hand).

    Update and Remove deprecated variables from Cisco Nexus Config.
    * Deprecated variables include vlan_name_prefix, svi_round_robin,
      provider_vlan_name_prefix, persistent_switch_config,
      never_cache_ssh_connection, ssh_port, switch_replay_count,
      nexus_driver, and host_key_checks.
    * Change config replay to on by defaulting switch_heartbeat_time=30.
    * Replaced method of configurating host_ports_mapping config.

    Change-Id: Iee2f869c4054f1120d224994aba8c827f981e6c0
    Closes-bug: #1793379
    (cherry picked from commit f45169f38db4333d60841136fe3fab951221eeb6)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron rocky-eol release.