Neutron uses the Nova API public endpoint which may not be always reachable from the node running the Neutron service

[Brent Eagles]

Originally reported https://bugzilla.redhat.com/show_bug.cgi?id=1433750
Neutron uses the Nova API public endpoint which may not be always reachable from the node running the Neutron services. We could instead the internal endpoint as this should be reachable from nodes which don't have access to the public endpoint network.

Scenario where this issue could show up:
Neutron API services are running on a different role than the controller running HAProxy where the public endpoints are binding. The Neutron role is not connected to the OSP-d External network since it runs internal only services and outgoing traffic to the External network from this role nodes is not allowed.

Version-Release number of selected component (if applicable):
openstack-tripleo-heat-templates-6.0.0-0.20170307170102.3134785.0rc2.el7ost.noarch

How reproducible:
100%

Steps to Reproduce:
1. Deploy overcloud
2. Check /etc/neutron/neutron.conf

Actual results:
[nova]

#
# From neutron
#

# Name of nova region to use. Useful if keystone manages more than one region.
# (string value)
#region_name = <None>

# Type of the nova endpoint to use. This endpoint will be looked up in the
# keystone catalog and should be one of public, internal or admin. (string
# value)
# Allowed values: public, admin, internal
#endpoint_type = public

Expected results:
endpoint_type = internal

[Brent Eagles (beagles)]

We aren't configuring this at all at the moment so the current value reflects the neutron's default value.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/536944

[Brent Eagles (beagles)]

puppet-neutron patch for configuring endpoint_type: https://review.openstack.org/#/c/536942/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/536942
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=ae730fb95bba7303baedf8fa5fc764e43cdefee5
Submitter: Zuul
Branch: master

commit ae730fb95bba7303baedf8fa5fc764e43cdefee5
Author: Brent Eagles <email address hidden>
Date: Tue Jan 23 15:58:55 2018 -0330

    Add param for controlling which nova endpoint is used

    This patch adds the 'neutron::notifications::endpoint_type' parameter
    to allow controlling which endpoint from the keystone catalog is used
    when communicating with nova.

    Change-Id: I4d17fb08634c3da3ac59a7c1fe728657e4da2c3f
    Partial-Bug: #1745002

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/536944
Reason: Gate resets is causing issue to land a critical patch (538346) - I need to clear the gate until 538346 is merged. Please do not restore this patch, I'll take care of it.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/536944
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=966f4a7092c22aefee63a26f67a93aaca1b71bfe
Submitter: Zuul
Branch: master

commit 966f4a7092c22aefee63a26f67a93aaca1b71bfe
Author: Brent Eagles <email address hidden>
Date: Tue Jan 23 16:14:10 2018 -0330

    Configure neutron notifier to use internal endpoint type for nova

    Configure neutron so it selects the internal endpoint from the keystone
    catalog for communicating with nova.

    Depends-On: I4d17fb08634c3da3ac59a7c1fe728657e4da2c3f
    Change-Id: Ib599161737fc432e4e0fe1e6aa27bbbc43cd7afd
    Closes-Bug: #1745002

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 8.0.0.0rc1 release candidate.