Several neutron templates are missing Debug configs

[Brent Eagles]

While https://review.openstack.org/#/c/521191/ adds missing options to enable Debug on a few neutron agents, there are more that are missing, e.g. neutron-sriov-agent, neutron-ovs-agent, etc.

[Brent Eagles (beagles)]

After looking into this further, it seems more of a long standing issue in puppet-neutron. Some of the class parameters are set to have false as a default for the debug configuration where it should be $::os_service_default. If they were done correctly, debug option (Debug or NeutronDebug) written into neutron.conf through neutron-base would've enabled debugging since it is included in the command line.

At first glance the affected files are:

agents/metadata.pp
agents/l3.pp
agents/l2gw.pp
agents/metering.pp

[Brent Eagles (beagles)]

I've marked as high because this not working correctly has negatively impacted CI maintenance and debugging.

[Brent Eagles (beagles)]

Proposed fix https://review.openstack.org/#/c/521258/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-neutron 12.1.0 release.