project_name should be set to tenant_name if the latter is used

[Jerzy Mikolajczak]

When one writes his own manifest using:

class { 'neutron::server':
  password => 'p4ssw0rd',
  tenant_name => 'my-own-tenant'
}

one ends up with this in neutron.conf:
[keystone_authtoken]
...
tenant_name=my-own-tenant
project_name=services
username=neutron
password=p4ssw0rd
...

project_name is being set to 'services' as default in puppet-neutron

And project_name is the only one being parsed by neutron-server process and not the tenant_name.
So You get user neutron with p4ssw0rd as a password in tenant 'services' and not in 'my-own-tenant' which ends with failed authentication and 500 Internal Server Error.
Actually, tenant_name variable is not being read/parsed from neutron.conf (tested on devstack liberty/mitaka) at all.

project_name is crucial and tenant_name can be set to anything or can be completely omitted.

I think if puppet-neutron user/operator passes tenant_name variable he should be presented with warning (about using tenant_name) and project_name should be set to tenant_name value.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/297028

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/297028
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=dd6fec30654fa5accaad46b0248d833afec1ed67
Submitter: Jenkins
Branch: master

commit dd6fec30654fa5accaad46b0248d833afec1ed67
Author: Jerzy Mikolajczak <email address hidden>
Date: Thu Mar 24 12:00:29 2016 +0100

    Fix useless tenant_name parameter being set

    tenant_name parameter is not being used anymore.
    Add deprecation warning and copy its value to project_name.

    Closes-bug: #1560850

    Change-Id: Ic168811636608e5f951e0989a042909fbe6ba7b9

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-neutron 9.0.0 release.