providers, like neutron_network, neutron_subnet, fails if Neutron CLI throw warnings

[Sergey Vasilenko]

If OPenstack CLI throw warnings, like:
http://paste.openstack.org/show/477032/

Deployment may fail:
http://paste.openstack.org/show/477035/

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/238156

[Emilien Macchi (emilienm)]

There already is a patch: https://review.openstack.org/#/c/237610

Please talk each others and find a consensus.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/238156
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=79f0e636c07b80b2c6699d934b42641bfef4352b
Submitter: Jenkins
Branch: master

commit 79f0e636c07b80b2c6699d934b42641bfef4352b
Author: Sergey Vasilenko <email address hidden>
Date: Wed Oct 21 19:23:31 2015 +0300

    Use json output instead plain-text

    Openstack CLI utilities can return warning messages while
    run to stderr. It's a normal behavior for Openstack CLI.
    But Puppet mixs stderr and stdout for commands.

    For preventing parsing warning messages,
    I propose got response from Neutron CLI as JSON if it required
    and parse it by ruby JSON parser.

    JSON is a more usable format for interprocess communication,
    than plain-text or CSV.

    Change-Id: Iba1105bc119272715fa211ac129a366fe50cbf47
    Closes-bug: #1508511

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/263874

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/263874
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=e8e49e3862f048eec016ddbb50b7c86a8348571b
Submitter: Jenkins
Branch: master

commit e8e49e3862f048eec016ddbb50b7c86a8348571b
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Jan 5 20:32:59 2016 +0100

    Correctly parse csv even with extra output.

    This patch ensure that the csv output is cleaned up from extra warning
    message from the cli.

    This has been addressed first here[1], then there[2] which had to be
    reverted there[3]. So here again a fix.

    Closes-bug: #1508511

    [1] https://review.openstack.org/#/c/237610/3
    [2] https://review.openstack.org/#/c/238156/
    [3] https://review.openstack.org/#/c/262809/

    Change-Id: I3a2e677c2bd349322cfb08d5dc73c1ced38c3f60

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/275297

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/275297
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=3794e88c4e6cbf3a14125f19a1be9fa862718583
Submitter: Jenkins
Branch: stable/liberty

commit 3794e88c4e6cbf3a14125f19a1be9fa862718583
Author: Sofer Athlan-Guyot <email address hidden>
Date: Tue Jan 5 20:32:59 2016 +0100

    Correctly parse csv even with extra output.

    This patch ensure that the csv output is cleaned up from extra warning
    message from the cli.

    This has been addressed first here[1], then there[2] which had to be
    reverted there[3]. So here again a fix.

    Closes-bug: #1508511

    [1] https://review.openstack.org/#/c/237610/3
    [2] https://review.openstack.org/#/c/238156/
    [3] https://review.openstack.org/#/c/262809/

    Change-Id: I3a2e677c2bd349322cfb08d5dc73c1ced38c3f60
    (cherry picked from commit e8e49e3862f048eec016ddbb50b7c86a8348571b)

[Doug Hellmann (doug-hellmann)]

This issue was fixed in the openstack/puppet-neutron 7.1.0 release.