puppet-murano

Unable to disable log_dir by setting to false

Bug #1600294 reported by Bart Wensley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-ceilometer
Fix Released
Undecided
Nikita Karpin
puppet-congress
Fix Released
Undecided
Nikita Karpin
puppet-designate
Fix Released
Undecided
Nikita Karpin
puppet-glance
Fix Released
Undecided
Nikita Karpin
puppet-heat
Fix Released
Undecided
Nikita Karpin
puppet-ironic
Fix Released
Undecided
Nikita Karpin
puppet-keystone
Fix Released
Undecided
Nikita Karpin
puppet-manila
Fix Released
Undecided
Nikita Karpin
puppet-murano
Fix Released
Undecided
Nikita Karpin
puppet-nova
Fix Released
High
Nikita Karpin
puppet-octavia
Fix Released
Undecided
Nikita Karpin
puppet-oslo
Fix Released
Undecided
Nikita Karpin
puppet-panko
Fix Released
Undecided
Nikita Karpin
puppet-sahara
Fix Released
Undecided
Nikita Karpin
puppet-trove
Fix Released
Undecided
Nikita Karpin
puppet-watcher
Fix Released
Undecided
Nikita Karpin

Bug Description

Commit 872b1774 broke the ability to set log_dir to false in oslo::log in order to disable logging to a file.

The following code was removed from manifests/init.pp and should have been added to manifests/logging.pp, but wasn't:
- if $log_dir {
- file { $log_dir:
- ensure => directory,
- mode => '0750',
- owner => 'nova',
- group => $::nova::params::nova_log_group,
- require => Package['nova-common'],
- }
- nova_config { 'DEFAULT/log_dir': value => $log_dir;}
- } else {
- nova_config { 'DEFAULT/log_dir': ensure => absent;}
- }

The end result is that setting log_dir to false puts "log_dir=False" in nova.conf, which is interpreted as a directory by the nova processes resulting a failure on startup.

Matt Fischer (mfisch)
Changed in puppet-nova:
status: New → Triaged
importance: Undecided → High
Nikita Karpin (mkarpin)
Changed in puppet-nova:
assignee: nobody → Nikita Karpin (mkarpin)
Nikita Karpin (mkarpin)
Changed in puppet-congress:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-ceilometer:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-heat:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-oslo:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-panko:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-glance:
assignee: nobody → Nikita Karpin (mkarpin)
Nikita Karpin (mkarpin)
Changed in puppet-ironic:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-manila:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-designate:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-murano:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-trove:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-watcher:
assignee: nobody → Nikita Karpin (mkarpin)
Nikita Karpin (mkarpin)
Changed in puppet-keystone:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-sahara:
assignee: nobody → Nikita Karpin (mkarpin)
Changed in puppet-octavia:
assignee: nobody → Nikita Karpin (mkarpin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/382344

Changed in puppet-nova:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-nova (master)

Reviewed: https://review.openstack.org/382344
Committed: https://git.openstack.org/cgit/openstack/puppet-nova/commit/?id=e8a4765c624cc8b69ad9b0a7bd11202c76df4c34
Submitter: Jenkins
Branch: master

commit e8a4765c624cc8b69ad9b0a7bd11202c76df4c34
Author: Mykyta Karpin <email address hidden>
Date: Wed Oct 5 14:39:55 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: Ia89855dd72e2a560601ac0f1d92e15714c805ed6
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-congress (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384449

Changed in puppet-congress:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-oslo (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384454

Changed in puppet-oslo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ceilometer (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384463

Changed in puppet-ceilometer:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384494

Changed in puppet-heat:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-panko (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384502

Changed in puppet-panko:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384508

Changed in puppet-glance:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384524

Changed in puppet-ironic:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384558

Changed in puppet-trove:
status: New → In Progress
Changed in puppet-watcher:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-watcher (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384560

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384573

Changed in puppet-designate:
status: New → In Progress
Changed in puppet-murano:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384575

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384588

Changed in puppet-keystone:
status: New → In Progress
Changed in puppet-manila:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384589

Changed in puppet-octavia:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-octavia (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384591

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-sahara (master)

Fix proposed to branch: master
Review: https://review.openstack.org/384597

Changed in puppet-sahara:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-murano (master)

Reviewed: https://review.openstack.org/384575
Committed: https://git.openstack.org/cgit/openstack/puppet-murano/commit/?id=887083a4c4d99eec25065b2125390955e3ab356d
Submitter: Jenkins
Branch: master

commit 887083a4c4d99eec25065b2125390955e3ab356d
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 17:50:19 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I901cf902415becc2918dd2ce175f9dfe0faf6462
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-octavia (master)

Reviewed: https://review.openstack.org/384591
Committed: https://git.openstack.org/cgit/openstack/puppet-octavia/commit/?id=6c74a52ca51a325abbf351767051fceec50df292
Submitter: Jenkins
Branch: master

commit 6c74a52ca51a325abbf351767051fceec50df292
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 18:18:45 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I506bb0e4bdadb4ef095a70c59191837922141c17
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-watcher (master)

Reviewed: https://review.openstack.org/384560
Committed: https://git.openstack.org/cgit/openstack/puppet-watcher/commit/?id=13da01d1f39a598509358fc244be23f55c5d83f8
Submitter: Jenkins
Branch: master

commit 13da01d1f39a598509358fc244be23f55c5d83f8
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 17:33:32 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I78b06943b0b1d6d6c40fa0ac4b8d45b19de5a6a5
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-panko (master)

Reviewed: https://review.openstack.org/384502
Committed: https://git.openstack.org/cgit/openstack/puppet-panko/commit/?id=2016864645b442b920d92db5ee372c650efc83d7
Submitter: Jenkins
Branch: master

commit 2016864645b442b920d92db5ee372c650efc83d7
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 16:22:21 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: Ic3981682a1ea0d41bcea67c797f003b31f4ec517
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-congress (master)

Reviewed: https://review.openstack.org/384449
Committed: https://git.openstack.org/cgit/openstack/puppet-congress/commit/?id=1d732c2c9fced1b2fd64dca8df60dc7d6973e9ef
Submitter: Jenkins
Branch: master

commit 1d732c2c9fced1b2fd64dca8df60dc7d6973e9ef
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 14:54:15 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I9135e6051488049a31d9fd83ec6decaf7ba7e5c2
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-oslo (master)

Reviewed: https://review.openstack.org/384454
Committed: https://git.openstack.org/cgit/openstack/puppet-oslo/commit/?id=1ddc04fc556d7c8f9fcb40b2d80d7a0ae6c05680
Submitter: Jenkins
Branch: master

commit 1ddc04fc556d7c8f9fcb40b2d80d7a0ae6c05680
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 15:02:16 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I4e9e5b5526aff37f8912bc96ec537f8d2c9ee519
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ironic (master)

Reviewed: https://review.openstack.org/384524
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=18cc687589b6e35ef4bc31a7121ecec2fe9e4466
Submitter: Jenkins
Branch: master

commit 18cc687589b6e35ef4bc31a7121ecec2fe9e4466
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 16:53:59 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: If3ca39111a501e6768ecc94a5bf5f22b3a94879b
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-manila (master)

Reviewed: https://review.openstack.org/384589
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=010ff086e4447eaa4d8a4e5b6593449534f88291
Submitter: Jenkins
Branch: master

commit 010ff086e4447eaa4d8a4e5b6593449534f88291
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 18:15:57 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: Iefd3f0e0138ceb73e299bd55fb22ad2f4ab4caa2
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-sahara (master)

Reviewed: https://review.openstack.org/384597
Committed: https://git.openstack.org/cgit/openstack/puppet-sahara/commit/?id=184a3b399c2706b8d91618a9078c4aa3aba517ac
Submitter: Jenkins
Branch: master

commit 184a3b399c2706b8d91618a9078c4aa3aba517ac
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 18:28:26 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: Ia0be1a31ec59752ebac6430446aebcb766f350c4
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-heat (master)

Reviewed: https://review.openstack.org/384494
Committed: https://git.openstack.org/cgit/openstack/puppet-heat/commit/?id=468a12493da6d2261a7d23c7b0f0815c735bc52e
Submitter: Jenkins
Branch: master

commit 468a12493da6d2261a7d23c7b0f0815c735bc52e
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 16:13:34 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: Ifba8e0b5f9119426a8093a0124e5bb5d4e89b20a
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceilometer (master)

Reviewed: https://review.openstack.org/384463
Committed: https://git.openstack.org/cgit/openstack/puppet-ceilometer/commit/?id=765557b9dc4a42cbe901ff73794344a8f1f899a2
Submitter: Jenkins
Branch: master

commit 765557b9dc4a42cbe901ff73794344a8f1f899a2
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 15:10:27 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I283453057845af1ec8e4e1e0419db2e9d5893abf
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (master)

Reviewed: https://review.openstack.org/384588
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=60a114700dc7dab416e76c2868bdb849660544d1
Submitter: Jenkins
Branch: master

commit 60a114700dc7dab416e76c2868bdb849660544d1
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 18:11:28 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I2e473b45f511d2edef608fc245f68d75de59e7f9
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-glance (master)

Reviewed: https://review.openstack.org/384508
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=88713c96f7e3e8eb40f600e85f3586ee7eed3f42
Submitter: Jenkins
Branch: master

commit 88713c96f7e3e8eb40f600e85f3586ee7eed3f42
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 16:33:43 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I280409ece958a0b2c5e25cc6ad511834b8cec47c
    Partial-Bug: #1600294

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-trove (master)

Reviewed: https://review.openstack.org/384558
Committed: https://git.openstack.org/cgit/openstack/puppet-trove/commit/?id=39062e3ac92691f835b5a05ed0eea56d55f707cd
Submitter: Jenkins
Branch: master

commit 39062e3ac92691f835b5a05ed0eea56d55f707cd
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 17:30:07 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: Id7bbb1aa48c282269d1dffe0bc1ccd7afd1bf6f5
    Partial-Bug: #1600294

Nikita Karpin (mkarpin)
Changed in puppet-ceilometer:
status: In Progress → Fix Committed
Changed in puppet-glance:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-designate (master)

Reviewed: https://review.openstack.org/384573
Committed: https://git.openstack.org/cgit/openstack/puppet-designate/commit/?id=b49fb7856335a268860f143b671ec9ded0fd2753
Submitter: Jenkins
Branch: master

commit b49fb7856335a268860f143b671ec9ded0fd2753
Author: Mykyta Karpin <email address hidden>
Date: Mon Oct 10 17:44:50 2016 +0300

    Fix documentation for log_dir parameter

    Change-Id: I57127a32c40c4c47c40a71891b8ea10c2a71d838
    Partial-Bug: #1600294

Nikita Karpin (mkarpin)
Changed in puppet-congress:
status: In Progress → Fix Committed
Changed in puppet-heat:
status: In Progress → Fix Committed
Changed in puppet-ironic:
status: In Progress → Fix Committed
Changed in puppet-keystone:
status: In Progress → Fix Committed
Changed in puppet-manila:
status: In Progress → Fix Committed
Changed in puppet-murano:
status: In Progress → Fix Committed
Changed in puppet-nova:
status: In Progress → Fix Committed
Changed in puppet-octavia:
status: In Progress → Fix Committed
Changed in puppet-oslo:
status: In Progress → Fix Committed
Changed in puppet-panko:
status: In Progress → Fix Committed
Changed in puppet-sahara:
status: In Progress → Fix Committed
Changed in puppet-trove:
status: In Progress → Fix Committed
Changed in puppet-watcher:
status: In Progress → Fix Committed
Tobias Urdin (tobias-urdin)
Changed in puppet-glance:
status: Fix Committed → Fix Released
Tobias Urdin (tobias-urdin)
Changed in puppet-keystone:
status: Fix Committed → Fix Released
Tobias Urdin (tobias-urdin)
Changed in puppet-nova:
status: Fix Committed → Fix Released
Tobias Urdin (tobias-urdin)
Changed in puppet-ceilometer:
status: Fix Committed → Fix Released
Changed in puppet-congress:
status: Fix Committed → Fix Released
Changed in puppet-heat:
status: Fix Committed → Fix Released
Changed in puppet-ironic:
status: Fix Committed → Fix Released
Changed in puppet-manila:
status: Fix Committed → Fix Released
Changed in puppet-murano:
status: Fix Committed → Fix Released
Changed in puppet-octavia:
status: Fix Committed → Fix Released
Changed in puppet-oslo:
status: Fix Committed → Fix Released
Changed in puppet-panko:
status: Fix Committed → Fix Released
Changed in puppet-sahara:
status: Fix Committed → Fix Released
Changed in puppet-trove:
status: Fix Committed → Fix Released
Changed in puppet-watcher:
status: Fix Committed → Fix Released
Changed in puppet-designate:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.