Htachi NAS: Wrong parameter to set username

[Takashi Kajinami]

The Hitachi NAS driver accepts not the hitachi_hnas_username parameter but the hitachi_hnas_user parameter.
Current implementation of the manila::share::hitachi_hnas defined resource type uses the wrong parameter name thus it can't configure the required parameters properly.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-manila/+/837244

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-manila/+/837244
Committed: https://opendev.org/openstack/puppet-manila/commit/69bdd9e018b85df8b85b502a64295cbb9adff3aa
Submitter: "Zuul (22348)"
Branch: master

commit 69bdd9e018b85df8b85b502a64295cbb9adff3aa
Author: Takashi Kajinami <email address hidden>
Date: Mon Apr 11 11:02:14 2022 +0900

    HNAS: Fix the wrong parameter to set username

    This change fixes the wrong parameter to set username of HNAS share
    driver. The hitachi_hnas_username parameter has never been implemneted
    and should be ``hitachi_hnas_user`` instead.

    The user parameter is required by the driver, and the driver can't
    start with the current wrong settings.

    Because the configuration has been 'broken' since 2016, it'd be fair to
    assume no user is using this actually. So the parameter is directly
    renamed without deprecation step.

    Closes-Bug: #1968514
    Change-Id: I247dac538afc85544cc9e41d37a029806321e009

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-manila 21.0.0 release.