THT deploys manila.conf with deprecated settings for neutron and nova

[David Vallee Delisle]

Description
===========
Since this commit [1], keystone doesn't support v2.0 requests anymore. When deployed with THT, manila.conf is configured with neutron_admin_* and nova_admin_* which are not supporting the use of a domain for keystone v3 auth.

[1] https://review.openstack.org/#/c/504465/

Steps to reproduce
==================
Deploy manila-share
Create a manila-share

Expected result
===============
We should have a share

Actual result
=============
Manila-share is getting a 404 on keystone /v2.0/tokens

Environment
===========
Queens

Fix
===

When using these settings, it works:

~~~
[nova]
catalog_info=compute:nova:publicURL
catalog_admin_info=compute:nova:adminURL
api_insecure=False
username=nova
password=xxx
project_name=service
project_domain_name=Default
user_domain_name=Default
auth_url=http://192.168.1.6:5000/

[neutron]
auth_type=password
url=http://192.168.1.6:9696
url_timeout=30
username=neutron
password=xxx
project_name=service
project_domain_name=Default
user_domain_name=Default
auth_url=http://192.168.1.6:5000/
api_insecure=False
auth_strategy=keystone
~~~

[David Vallee Delisle (valleedelisle)]

I'll create a new puppet file using the doc [1] as a reference.

[1] https://docs.openstack.org/manila/queens/configuration/shared-file-systems/samples/manila.conf.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/624137

[OpenStack Infra (hudson-openstack)]

Change abandoned by Victoria Martinez de la Cruz (<email address hidden>) on branch: master
Review: https://review.openstack.org/624137
Reason: Change not needed, abandoning it

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/616698
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=5ae8e2882b3e8229ea0007938315f5145e4f5f8a
Submitter: Zuul
Branch: master

commit 5ae8e2882b3e8229ea0007938315f5145e4f5f8a
Author: David Vallee Delisle <email address hidden>
Date: Thu Nov 8 17:09:45 2018 -0500

    Updating nova and neutron configuration

    Since we stopped support of keystonev2, we need to be able to specify a
    domain in neutron and nova configuration. Might as well add all the
    options and remove the deprecated ones.

    Co-authored-by: Victoria Martinez de la Cruz <email address hidden>
    Change-Id: I745a170ac4458a3f13efc255fc37540a11b54274
    Closes-Bug: #1802393

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/627014
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=cd866766150e139944c5c22125e44da85dd5a197
Submitter: Zuul
Branch: master

commit cd866766150e139944c5c22125e44da85dd5a197
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Fri Dec 21 19:15:53 2018 -0300

    Update auth parameters

    Some parameters have been deprecated in puppet-manila
    Whereas we are picking up deprecated parameters, it's good
    that we fix this already here as well.

    Change-Id: I29df069bd90eacdd01c9c600cfaebce22fe15731
    Depends-On: I745a170ac4458a3f13efc255fc37540a11b54274
    Partial-Bug: #1802393

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/628963

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/628964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/628963
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=8fb1fa1077f3a39274bcf24eea20197175c74605
Submitter: Zuul
Branch: stable/rocky

commit 8fb1fa1077f3a39274bcf24eea20197175c74605
Author: David Vallee Delisle <email address hidden>
Date: Thu Nov 8 17:09:45 2018 -0500

    Updating nova and neutron configuration

    Since we stopped support of keystonev2, we need to be able to specify a
    domain in neutron and nova configuration. Might as well add all the
    options and remove the deprecated ones.

    Co-authored-by: Victoria Martinez de la Cruz <email address hidden>
    Change-Id: I745a170ac4458a3f13efc255fc37540a11b54274
    Closes-Bug: #1802393
    (cherry picked from commit 5ae8e2882b3e8229ea0007938315f5145e4f5f8a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/628964
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=d4eaa2736bcc8e3d2188cf9f457f4a09299c7c13
Submitter: Zuul
Branch: stable/queens

commit d4eaa2736bcc8e3d2188cf9f457f4a09299c7c13
Author: David Vallee Delisle <email address hidden>
Date: Thu Nov 8 17:09:45 2018 -0500

    Updating nova and neutron configuration

    Since we stopped support of keystonev2, we need to be able to specify a
    domain in neutron and nova configuration. Might as well add all the
    options and remove the deprecated ones.

    Co-authored-by: Victoria Martinez de la Cruz <email address hidden>
    Change-Id: I745a170ac4458a3f13efc255fc37540a11b54274
    Closes-Bug: #1802393
    (cherry picked from commit 5ae8e2882b3e8229ea0007938315f5145e4f5f8a)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/629484

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/629485

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/629484
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3cb95e16383a42d596d2db14ada606230abbb69b
Submitter: Zuul
Branch: stable/rocky

commit 3cb95e16383a42d596d2db14ada606230abbb69b
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Fri Dec 21 19:15:53 2018 -0300

    Update auth parameters

    Some parameters have been deprecated in puppet-manila
    Whereas we are picking up deprecated parameters, it's good
    that we fix this already here as well.

    Change-Id: I29df069bd90eacdd01c9c600cfaebce22fe15731
    Depends-On: I745a170ac4458a3f13efc255fc37540a11b54274
    Partial-Bug: #1802393
    (cherry picked from commit cd866766150e139944c5c22125e44da85dd5a197)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/629485
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=c39b37f6c259da7e8cf9e566289ce6b45d720d06
Submitter: Zuul
Branch: stable/queens

commit c39b37f6c259da7e8cf9e566289ce6b45d720d06
Author: Victoria Martinez de la Cruz <email address hidden>
Date: Fri Dec 21 19:15:53 2018 -0300

    Update auth parameters

    Some parameters have been deprecated in puppet-manila
    Whereas we are picking up deprecated parameters, it's good
    that we fix this already here as well.

    Change-Id: I29df069bd90eacdd01c9c600cfaebce22fe15731
    Depends-On: I745a170ac4458a3f13efc255fc37540a11b54274
    Partial-Bug: #1802393
    (cherry picked from commit cd866766150e139944c5c22125e44da85dd5a197)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-manila 14.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-manila 12.5.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-manila 13.3.2 release.