Missing or incomplete coverage of the rspec unit tests for Types and Providers

Bug #1440401 reported by Gael Chamoulaud
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-ceilometer
Low
Gael Chamoulaud
puppet-cinder
Low
liaonanhai
puppet-designate
Low
alexey-mr
puppet-glance
Low
Nikita Karpin
puppet-heat
Low
STEW TY
puppet-ironic
Low
Michael Glaser
puppet-keystone
Low
Michael Glaser
puppet-manila
Low
Jin Li
puppet-neutron
Low
Unassigned
puppet-nova
Low
Unassigned
puppet-swift
Low
Unassigned
puppet-trove
Low
Unassigned

Bug Description

A majority of puppet modules don't have any Unit Tests for Types and Providers. Most of them already have some but doesn't cover all the customs providers/types.

description: updated
summary: - Missing rspec unit tests for Types and Providers
+ Missing or incomplete rspec unit tests for Types and Providers
summary: - Missing or incomplete rspec unit tests for Types and Providers
+ Missing or incomplete coverage of the rspec unit tests for Types and
+ Providers
Changed in puppet-ceilometer:
importance: Undecided → Low
Changed in puppet-trove:
importance: Undecided → Low
Changed in puppet-swift:
importance: Undecided → Low
Changed in puppet-nova:
importance: Undecided → Low
Changed in puppet-neutron:
importance: Undecided → Low
Changed in puppet-manila:
importance: Undecided → Low
Changed in puppet-keystone:
importance: Undecided → Low
Changed in puppet-ironic:
importance: Undecided → Low
Changed in puppet-heat:
importance: Undecided → Low
Changed in puppet-glance:
importance: Undecided → Low
Changed in puppet-designate:
importance: Undecided → Low
Changed in puppet-cinder:
importance: Undecided → Low
Changed in puppet-ceilometer:
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ceilometer (master)

Reviewed: https://review.openstack.org/170488
Committed: https://git.openstack.org/cgit/stackforge/puppet-ceilometer/commit/?id=0ec70ff60f620a1af29ae64a646ee7e5ad98ebb9
Submitter: Jenkins
Branch: master

commit 0ec70ff60f620a1af29ae64a646ee7e5ad98ebb9
Author: Gael Chamoulaud <email address hidden>
Date: Fri Apr 3 15:15:02 2015 +0200

    spec: Add Unit Tests for Ceilometer_config type/provider

    Change-Id: I0527683055829d3a3b6ff465c48a0caf44c41595
    Partial-bug: #1440401
    Signed-off-by: Gael Chamoulaud <email address hidden>

Changed in puppet-cinder:
status: New → Confirmed
Changed in puppet-designate:
status: New → Confirmed
Changed in puppet-glance:
status: New → Confirmed
Changed in puppet-heat:
status: New → Confirmed
Changed in puppet-ironic:
status: New → Confirmed
Changed in puppet-keystone:
status: New → Confirmed
Changed in puppet-manila:
status: New → Confirmed
Changed in puppet-neutron:
status: New → Confirmed
Changed in puppet-nova:
status: New → Confirmed
Changed in puppet-swift:
status: New → Confirmed
Changed in puppet-trove:
status: New → Confirmed
Revision history for this message
Richard Raseley (richard-raseley) wrote :

This was also called out as an (non-blocking) issue during the process to designate the module 'Puppet Approved'.

liaonanhai (nanhai-liao)
Changed in puppet-cinder:
assignee: nobody → liaonanhai (nanhai-liao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/210959

Changed in puppet-cinder:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-cinder (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/210959
Reason: in favor of https://review.openstack.org/#/c/211886

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290437

Changed in puppet-glance:
assignee: nobody → Nikita Karpin (mkarpin)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/290489

Changed in puppet-designate:
assignee: nobody → alexey-mr (alexey-morlang)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-glance (master)

Reviewed: https://review.openstack.org/290437
Committed: https://git.openstack.org/cgit/openstack/puppet-glance/commit/?id=7d1c73ba0a3433e9c8643756373a3364a5355a7f
Submitter: Jenkins
Branch: master

commit 7d1c73ba0a3433e9c8643756373a3364a5355a7f
Author: Mykyta Karpin <email address hidden>
Date: Wed Mar 9 14:47:48 2016 +0300

    spec: Add Unit Tests for glance paste_ini types/providers

    Change-Id: Ia6688b80f983c76db5b076eafc842bfe2be4481b
    Partial-bug: #1440401

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-designate (master)

Reviewed: https://review.openstack.org/290489
Committed: https://git.openstack.org/cgit/openstack/puppet-designate/commit/?id=2d6b1d844d8a4559b1f48e61da8bf9b7375f41aa
Submitter: Jenkins
Branch: master

commit 2d6b1d844d8a4559b1f48e61da8bf9b7375f41aa
Author: alexey-mr <email address hidden>
Date: Wed Mar 9 16:18:57 2016 +0300

    spec: Add Unit-Test for designate rootwrap_config and
    paste_ini types/providers.

    Additionally it contains patch with autorequire of designate-common
    package for rootwrap_conf.

    Change-Id: I64a75948f30661706ee6338448d9f662d28e871f
    Partial-bug: #1440401

Changed in puppet-ironic:
assignee: nobody → Marcellin Fom Tchassem (mf6510)
Changed in puppet-swift:
assignee: nobody → Trevor McCasland (twm2016)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/304804

Changed in puppet-swift:
status: Confirmed → In Progress
Changed in puppet-neutron:
assignee: nobody → Trevor McCasland (twm2016)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/304836

Changed in puppet-neutron:
status: Confirmed → In Progress
Jin Li (jl7351)
Changed in puppet-manila:
assignee: nobody → Jin Li (jl7351)
Changed in puppet-trove:
assignee: nobody → Jin Li (jl7351)
assignee: Jin Li (jl7351) → nobody
STEW TY (stewie925)
Changed in puppet-heat:
assignee: nobody → STEW TY (stewie925)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/304881

Changed in puppet-heat:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-manila (master)

Fix proposed to branch: master
Review: https://review.openstack.org/304955

Changed in puppet-manila:
status: Confirmed → In Progress
Changed in puppet-keystone:
assignee: nobody → Mike_G (mg6596)
Changed in puppet-ironic:
assignee: Marcellin Fom Tchassem (mf6510) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-heat (master)

Reviewed: https://review.openstack.org/304881
Committed: https://git.openstack.org/cgit/openstack/puppet-heat/commit/?id=5ee00d6ffec7f5250fdf300bfb86121c7886afc7
Submitter: Jenkins
Branch: master

commit 5ee00d6ffec7f5250fdf300bfb86121c7886afc7
Author: stewie925 <email address hidden>
Date: Tue Apr 12 14:39:42 2016 -0700

    Add Unit Tests for heat_config type

    Partial-bug: #1440401

    Change-Id: I34a0eda08f52e5596e64ac6e7f5292f20d234683

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-neutron (master)

Reviewed: https://review.openstack.org/304836
Committed: https://git.openstack.org/cgit/openstack/puppet-neutron/commit/?id=990bbc0df6274bd750b0bfaa6fa20a444f750397
Submitter: Jenkins
Branch: master

commit 990bbc0df6274bd750b0bfaa6fa20a444f750397
Author: Trevor McCasland <email address hidden>
Date: Tue Apr 12 14:37:33 2016 -0500

    Add Unit Tests for Neutron_config type

    Change-Id: I93551cfd71d27584d69ec7d97898632f84521653
    Partial-bug: #1440401

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-swift (master)

Reviewed: https://review.openstack.org/304804
Committed: https://git.openstack.org/cgit/openstack/puppet-swift/commit/?id=a24f850a4b80c3cdd992cc4b3f407819e39367e7
Submitter: Jenkins
Branch: master

commit a24f850a4b80c3cdd992cc4b3f407819e39367e7
Author: Trevor McCasland <email address hidden>
Date: Tue Apr 12 12:44:40 2016 -0500

    Add Unit Tests for Swift_config type

    Change-Id: Ib431515f8472789def4a6dc4ab4fab97d698246f
    Partial-bug: #1440401

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-manila (master)

Reviewed: https://review.openstack.org/304955
Committed: https://git.openstack.org/cgit/openstack/puppet-manila/commit/?id=8e607c5b5f29ca6ce8daecd46aaa3c5818f4b556
Submitter: Jenkins
Branch: master

commit 8e607c5b5f29ca6ce8daecd46aaa3c5818f4b556
Author: JinLi <email address hidden>
Date: Tue Apr 12 21:58:23 2016 -0700

    Add Unit Tests for manila_config type

    *remove empty line

    Change-Id: Id8562dd2743993e6364a657e8e4e0716af148191
    Partial-bug: #1440401

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/306644

Changed in puppet-keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/307326

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-keystone (master)

Change abandoned by Michael Glaser (<email address hidden>) on branch: master
Review: https://review.openstack.org/307326
Reason: Incorrectly committed change

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (master)

Reviewed: https://review.openstack.org/306644
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=ff3c84d3cc519ff7d6e5849bde4705165d93f390
Submitter: Jenkins
Branch: master

commit ff3c84d3cc519ff7d6e5849bde4705165d93f390
Author: MikeG451 <email address hidden>
Date: Fri Apr 15 14:02:37 2016 -0700

    Add Unit Tests for keystone_config type

    Change-Id: Ieb34b1d9ff0d94e196d0ae4e07465fb7dd719b62
    Partial-bug: #1440401

Changed in puppet-ironic:
assignee: nobody → Michael Glaser (mikeg451)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/310579

Changed in puppet-ironic:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-ironic (master)

Reviewed: https://review.openstack.org/310579
Committed: https://git.openstack.org/cgit/openstack/puppet-ironic/commit/?id=ff87e2519c5dcfa84b28fc7f51db9bdfc12ddb88
Submitter: Jenkins
Branch: master

commit ff87e2519c5dcfa84b28fc7f51db9bdfc12ddb88
Author: MikeG451 <email address hidden>
Date: Wed Apr 27 13:01:04 2016 -0700

    Add Unit Tests for Ironic-config type

    Partial-bug: #1440401

    Change-Id: I5834bcf69db39fcd7287c0b9af5136d172410cda

Jin Li (jl7351)
Changed in puppet-nova:
assignee: nobody → Jin Li (jl7351)
Jin Li (jl7351)
Changed in puppet-nova:
assignee: Jin Li (jl7351) → nobody
Changed in puppet-swift:
assignee: Trevor McCasland (twm2016) → nobody
Changed in puppet-neutron:
assignee: Trevor McCasland (twm2016) → nobody
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers