unit tests fail on keystone::federation::shibboleth

[Emilien Macchi]

unit tests fails on shibbolet class:
http://logs.openstack.org/16/438116/1/check/gate-puppet-keystone-puppet-unit-3.6-centos-7/7a9358f/console.html#_2017-02-24_23_29_26_977959

2017-02-24 23:29:26.977959 | 1) keystone::federation::shibboleth behaves like Federation Shibboleth with only required parameters should contain Concat::Fragment[configure_shibboleth_on_port_5000] with target => "10-keystone_wsgi_main.conf" and order => 331
2017-02-24 23:29:26.977972 | Failure/Error:
2017-02-24 23:29:26.978003 | it { is_expected.to contain_concat__fragment('configure_shibboleth_on_port_5000').with({
2017-02-24 23:29:26.978022 | :target => "10-keystone_wsgi_main.conf",
2017-02-24 23:29:26.978039 | :order => params[:template_order],
2017-02-24 23:29:26.978048 | })}
2017-02-24 23:29:26.978055 |
2017-02-24 23:29:26.978104 | expected that the catalogue would contain Concat::Fragment[configure_shibboleth_on_port_5000]
2017-02-24 23:29:26.978146 | Shared Example Group: "Federation Shibboleth" called from ./spec/classes/keystone_federation_shibboleth_spec.rb:98
2017-02-24 23:29:26.978179 | # ./spec/classes/keystone_federation_shibboleth_spec.rb:61:in `block (4 levels) in <top (required)>'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/438716

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/438716
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=d369e3ab0fdc6d8a69b8a6428deaa89fc9066368
Submitter: Jenkins
Branch: master

commit d369e3ab0fdc6d8a69b8a6428deaa89fc9066368
Author: Alex Schultz <email address hidden>
Date: Mon Feb 27 11:20:35 2017 -0700

    Fix shibboleth tests

    This patch basically rewrites the shibboleth unit tests. The previous
    version was not properly running the invalid parameters cases and the
    cases for installing under Red Hat were not properly being exercised.

    Change-Id: Id578980cae370ad46187ea2ced0ae8dada1ef3ee
    Closes-Bug: #1667866

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/438804

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/438804
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=6d0f1879129eda4c65b626889bc70a373fc9f8de
Submitter: Jenkins
Branch: stable/ocata

commit 6d0f1879129eda4c65b626889bc70a373fc9f8de
Author: Alex Schultz <email address hidden>
Date: Mon Feb 27 11:20:35 2017 -0700

    Fix shibboleth tests

    This patch basically rewrites the shibboleth unit tests. The previous
    version was not properly running the invalid parameters cases and the
    cases for installing under Red Hat were not properly being exercised.

    Change-Id: Id578980cae370ad46187ea2ced0ae8dada1ef3ee
    Closes-Bug: #1667866
    (cherry picked from commit d369e3ab0fdc6d8a69b8a6428deaa89fc9066368)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/439059

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/439059
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=e667a45b11ab0f18280774eb912f104ec3d26c84
Submitter: Jenkins
Branch: stable/newton

commit e667a45b11ab0f18280774eb912f104ec3d26c84
Author: Alex Schultz <email address hidden>
Date: Mon Feb 27 11:20:35 2017 -0700

    Fix shibboleth tests

    This patch basically rewrites the shibboleth unit tests. The previous
    version was not properly running the invalid parameters cases and the
    cases for installing under Red Hat were not properly being exercised.

    Change-Id: Id578980cae370ad46187ea2ced0ae8dada1ef3ee
    Closes-Bug: #1667866
    (cherry picked from commit d369e3ab0fdc6d8a69b8a6428deaa89fc9066368)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-keystone 11.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-keystone 10.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-keystone 9.6.0 release.