module is broken because the retries in openstacklib

Bug #1529371 reported by Emilien Macchi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-keystone
Fix Released
Critical
Sofer Athlan-Guyot

Bug Description

A patch in openstacklib [1] broke keystone provider in puppet-keystone.

https://github.com/openstack/puppet-openstacklib/commit/701b6fe0acf56e9132e9b0a448f28670c714cedb

 Puppet::Provider::Keystone#fetch_domain should be false if the domain does not exist
     Failure/Error: expect(klass.fetch_domain('no_domain')).to be_falsey
     Mocha::ExpectationError:
       unexpected invocation: openstack(domain, show, --format, shell, no_domain)
     # ./spec/fixtures/modules/openstacklib/lib/puppet/provider/openstack.rb:87:in

     Failure/Error: expect(klass.fetch_project('no_project', 'Default')).to be_falsey
     Mocha::ExpectationError:
       unexpected invocation: openstack(project, show, --format, shell, no_project, --domain, Default)

     Failure/Error: expect(klass.fetch_user('no_user', 'Default')).to be_falsey
     Mocha::ExpectationError:
       unexpected invocation: openstack(user, show, --format, shell, no_user, --domain, Default)

Changed in puppet-keystone:
importance: Undecided → Critical
Changed in puppet-keystone:
assignee: nobody → Sofer Athlan-Guyot (sofer-athlan-guyot)
Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

Yes, I can reproduce it

Changed in puppet-keystone:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/261984

Changed in puppet-keystone:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-keystone (master)

Reviewed: https://review.openstack.org/261984
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=27e8c1e9c3ee5a89638d9f343c109c17f06a4e08
Submitter: Jenkins
Branch: master

commit 27e8c1e9c3ee5a89638d9f343c109c17f06a4e08
Author: Sofer Athlan-Guyot <email address hidden>
Date: Mon Dec 28 13:29:53 2015 +0100

    Adjust rspec tests for retries in openstacklib.

    A patch in openstacklib[1] broke the some rspec test in keystone. This
    adjust the test to match the new behavior of the lib.

    The request_timeout is fixed to 0 so that only one retry is done.
    Failure to do that would make the number of retries unknown and the time
    spend on the three failing tests around 60 seconds each.

    [1] https://github.com/openstack/puppet-openstacklib/commit/701b6fe0acf56e9132e9b0a448f28670c714cedb

    Change-Id: I6adc439a806cf209e2fae35446a15b07353a18c2
    Closes-Bug: #1529371

Changed in puppet-keystone:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.