domain name from id lookups return empty

[Richard Megginson]

When using the method `domain_name_from_id(id)`, sometimes the return value is `nil`. This function should never return `nil`. The domain should always exist for a given `id`.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/221119

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/221119
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=74f01da92f8de2fcb471ec5f9833ead1bff2dee1
Submitter: Jenkins
Branch: master

commit 74f01da92f8de2fcb471ec5f9833ead1bff2dee1
Author: Rich Megginson <email address hidden>
Date: Sat Sep 5 15:55:09 2015 -0600

    domain name from id lookups return empty

    If the given domain id is not available in the @domain_hash,
    look it up in Keystone and add it to the hash. Do not assume
    the @domain_hash can be populated once. It must take into
    account domains that are created later.
    This consolidates the various bits of code that reset the class
    variables in the provider superclass into spec_helper.rb - we must
    be consistent about resetting the variables to ensure the spec
    tests return consistent results.

    Closes-Bug: #1492843
    Change-Id: Ic475ca7f33c49784a0e5f4a432220cbf8b3ce635

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/222428

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222428
Committed: https://git.openstack.org/cgit/openstack/puppet-keystone/commit/?id=31d519a86a24bb20b01a6251c3084ad57cd22564
Submitter: Jenkins
Branch: stable/kilo

commit 31d519a86a24bb20b01a6251c3084ad57cd22564
Author: Rich Megginson <email address hidden>
Date: Sat Sep 5 15:55:09 2015 -0600

    domain name from id lookups return empty

    If the given domain id is not available in the @domain_hash,
    look it up in Keystone and add it to the hash. Do not assume
    the @domain_hash can be populated once. It must take into
    account domains that are created later.
    This consolidates the various bits of code that reset the class
    variables in the provider superclass into spec_helper.rb - we must
    be consistent about resetting the variables to ensure the spec
    tests return consistent results.

    Closes-Bug: #1492843
    Change-Id: Ic475ca7f33c49784a0e5f4a432220cbf8b3ce635
    (cherry picked from commit 74f01da92f8de2fcb471ec5f9833ead1bff2dee1)