Deploy fails if ironic::inspector::ipxe_timeout is not set

[Francesco Di Nucci]

Hello,
it looks like when ironic::inspector::ipxe_timeout is not set explicitly, although it is optional, deployment fails:

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, Failed to parse template ironic/inspector_ipxe.erb:
  Filepath: org/jruby/RubyKernel.java
  Line: 468
  Detail: invalid value for Integer(): "<SERVICE DEFAULT>"
(file: /etc/puppetlabs/code/environments/development/modules/ironic/manifests/inspector.pp, line: 424, column: 18) on node my-controller.example.com
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-ironic/+/913555

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-ironic/+/913555
Committed: https://opendev.org/openstack/puppet-ironic/commit/055a0f17490d9a1d2de7b8e4f4f7e29ee402b90b
Submitter: "Zuul (22348)"
Branch: master

commit 055a0f17490d9a1d2de7b8e4f4f7e29ee402b90b
Author: Takashi Kajinami <email address hidden>
Date: Mon Mar 18 20:12:42 2024 +0900

    inspector: Fix wrong type of default pxe_timeout

    The pxe_timeout parameter should be set to an integer value (or
    a string representing an integer) and can't be set to
    the os_service_default fact.

    Closes-Bug: #2058229
    Change-Id: I7b04e5586c82fc528f960beddfe50a7b355f6580

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/2023.2
Review: https://review.opendev.org/c/openstack/puppet-ironic/+/913616

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/puppet-ironic/+/913617

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-ironic/+/913617
Committed: https://opendev.org/openstack/puppet-ironic/commit/224679340d3495992fbe1ac0df344e7d3d55e215
Submitter: "Zuul (22348)"
Branch: master

commit 224679340d3495992fbe1ac0df344e7d3d55e215
Author: Takashi Kajinami <email address hidden>
Date: Tue Mar 19 13:41:49 2024 +0900

    Require valid values for (i)PXE parameters

    Related-Bug: #2058229
    Change-Id: I228074623f1400985bb7f5a4c187ac14cf28c435

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-ironic/+/913616
Committed: https://opendev.org/openstack/puppet-ironic/commit/496020fb1fcba6a1fee6a019b89c3d58d6acc475
Submitter: "Zuul (22348)"
Branch: stable/2023.2

commit 496020fb1fcba6a1fee6a019b89c3d58d6acc475
Author: Takashi Kajinami <email address hidden>
Date: Mon Mar 18 20:12:42 2024 +0900

    inspector: Fix wrong type of default pxe_timeout

    The pxe_timeout parameter should be set to an integer value (or
    a string representing an integer) and can't be set to
    the os_service_default fact.

    Conflicts:
            manifests/inspector.pp
            templates/inspector_ipxe.erb

    Closes-Bug: #2058229
    Change-Id: I7b04e5586c82fc528f960beddfe50a7b355f6580
    (cherry picked from commit 055a0f17490d9a1d2de7b8e4f4f7e29ee402b90b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 23.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-ironic 24.0.0 release.