inspector: Missing new line in dnsmasq.conf when dnsmasq_ip_subnets is used
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
puppet-ironic |
Fix Released
|
High
|
Takashi Kajinami |
Bug Description
While adding strict ^ and $ check in unit tests, it turned out that dnsmasq.conf is rendered wrongly when dnsmasq_ip_subnets is used.
```
port=0
interface=
dhcp-range=
dhcp-option-
dhcp-range=
dhcp-option=
dhcp-option-
dhcp-range=
dhcp-option=
dhcp-option=
dhcp-boot=
dhcp-sequential-ip
```
A line break should be added btween 192.168.2.1 and dhcp-range.
Changed in puppet-ironic: | |
importance: | Undecided → High |
assignee: | nobody → Takashi Kajinami (kajinamit) |
Changed in puppet-ironic: | |
status: | New → In Progress |
Reviewed: https:/ /review. opendev. org/c/openstack /puppet- ironic/ +/899910 /opendev. org/openstack/ puppet- ironic/ commit/ e1a89eb585aedca ba57fcfde158516 2d37a6c1ba
Committed: https:/
Submitter: "Zuul (22348)"
Branch: master
commit e1a89eb585aedca ba57fcfde158516 2d37a6c1ba
Author: Takashi Kajinami <email address hidden>
Date: Thu Nov 2 13:24:58 2023 +0900
inspector: Fix missing new line in dnsmasq.conf with multiple subnets
... and make pattern match for inspector dnsmasq.conf more
strict to detect missing new lines or unnecessary elements.
Closes-Bug: #2042526 a2cbcddaa3722d4 053eab3566f
Change-Id: I03abeb7c1519f5